xmega ADC structs

Log in or register to post comments
Go To Last Post
4 posts / 0 new
Author
Message
Chupa
Chupa's picture
Level: Wannabe
Joined: Sun. Sep 12, 2004
Posts: 99 View posts
Location: Clearwater, Florida, USA!
#1
Posted by Chupa: Sun. Mar 21, 2010 - 10:34 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Just when I though I had this new struct thing down I get stick on this:

I'm trying to config my ADC channel on my xmega 256A3 but cant seem to figure it out.

I got the other registers figured out, just not the config ones. Ive been looking over iox256a3.h for a bit now and am seeing things I never have before, which I obviously don't understand. 

void adc_setup(){
	ADCA.CTRLA |= ADC_ENABLE_bm; //enable ADC A
	ADCA.CTRLB |= ADC_FREERUN_bm | ADC_RESOLUTION1_bm; //turn on free running mode, results in 8 bits right justified
	//ADCA.CH_CTRLA |= ADC_CH_INPUTMODE_SINGLEENDED_gc; //WRONG
	//ADCA.ADC_CH0.CTRL = 1; //WRONG again!
}

Just looking for a little bump in the right direction! Trying to config a channel for ADC_CH_INPUTMODE_SINGLEENDED_gc mode

I appreciate it!

You don't gno-me!

Tags:

Tools, Compilers and General Programming
Top
ArnoldB
ArnoldB's picture
Level: Raving Lunatic
Joined: Thu. Nov 29, 2007
Posts: 3185 View posts
Posted by ArnoldB: Sun. Mar 21, 2010 - 11:47 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Read application note AVR1300.

Stealing Proteus doesn't make you an engineer.

Top
Bronze Marktheusch
theusch's picture
Level: 10k+ Postman
Joined: Mon. Feb 19, 2001
Posts: 39996 View posts
Location: Wisconsin USA
Posted by theusch: Mon. Mar 22, 2010 - 12:29 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Quote:

ADCA.CTRLA |=

This construct always rankles me. If this is indeed "adc_setup" then why isn't there first an assignment? Better yet unless there is a reason, do it all in one assignment, and save a few instruction words.

Reasons:
1) What if you call this more than once in varying stages of the program? The registers may >>not<< have the initial values.

2) If the rebuttal is "it is only called once, at startup, and I know the initial value" then why create a function?

3) Unless a reason, why stretch out init bit-by-bit? Save a few flash words. When you do a real app, you'll be happy with your niggardliness.

Lee

You can put lipstick on a pig, but it is still a pig.

I've never met a pig I didn't like, as long as you have some salt and pepper.

Top
Chupa
Chupa's picture
Level: Wannabe
Joined: Sun. Sep 12, 2004
Posts: 99 View posts
Location: Clearwater, Florida, USA!
Posted by Chupa: Mon. Mar 22, 2010 - 12:58 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

ArnoldB wrote:
Read application note AVR1300.

gerrr, totaly forgot about the xmega app notes. got it now, thanks!. 

ADCA.CH0.CTRL |= ADC_CH_INPUTMODE_SINGLEENDED_gc;

I add the OR out of habit. I'm not worried about speed/space right now. But I see where your coming from. There is no need for it in a setup function. Putting it in a function just makes main() easier to read/debug for me.

You don't gno-me!

Top