why isn't my avr working?

Log in or register to post comments
Go To Last Post
6 posts / 0 new
Author
Message
gicutabacaru
gicutabacaru's picture
Level: New Member
Joined: Sun. Mar 19, 2006
Posts: 13 View posts
Location: ROU
#1
Posted by gicutabacaru: Fri. Mar 31, 2006 - 10:24 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

i have tried to make a led flasher with many programs but none seems to work.I compiled them into avrstudio. my atmega 8535 has connected some leds, the hardware is ok, but the leds(diferent types) they just light continousl.i give here one of the programs.what's wrong?

.include "m8535def.inc"

.def Temp = R16

.org 0x0000

init:
ldi temp, 0b00000001 ;
out DDRD, temp ;

main:
ldi temp, 0b00000001 ;
out portd, temp ;

rcall delay ;

ldi temp, 0x00 ;
out portd, temp ;

rcall delay ;

rjmp main ;

delay: ;
; =============================
;
; 499998 cycles: about 1/2 seconds
; -----------------------------
; delaying 499995 cycles:
ldi R29, $0F
WGLOOP0: ldi R30, $37
WGLOOP1: ldi R31, $C9
WGLOOP2: dec R31
brne WGLOOP2
dec R30
brne WGLOOP1
dec R29
brne WGLOOP0
; -----------------------------
; delaying 3 cycles:
ldi R29, $01
WGLOOP3: dec R29
brne WGLOOP3
; =============================
ret

Tags:

Tools, Atmel Studio (AVR-related)
Top
leon_heller
leon_heller's picture
Level: Raving Lunatic
Joined: Fri. Jul 27, 2001
Posts: 7672 View posts
Location: St. Leonards-on-Sea (UK)
Posted by leon_heller: Fri. Mar 31, 2006 - 10:48 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

You haven't initialised the stack pointer! You'd have probably found the mistake if you had simulated the program.

Leon

Leon Heller G1HSM

Top
GerryKeely
GerryKeely's picture
Level: Hangaround
Joined: Thu. Jan 30, 2003
Posts: 100 View posts
Location: Ireland
Posted by GerryKeely: Fri. Mar 31, 2006 - 10:55 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

You have to load the stack pointer with RAMEND so that program can return correctly from the delay routine
add
ldi temp, low(RAMEND)
out SPL,temp
ldi temp, High(RAMEND)
out SPH,temp as part of your init sequence

Top
GerryKeely
GerryKeely's picture
Level: Hangaround
Joined: Thu. Jan 30, 2003
Posts: 100 View posts
Location: Ireland
Posted by GerryKeely: Fri. Mar 31, 2006 - 10:57 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Leon
Programs simulates "correctly" without setting stack pointer

Gerry

Top
Gold Markclawson
clawson's picture
Level: Moderator
Joined: Mon. Jul 18, 2005
Posts: 104979 View posts
Location: (using avr-gcc in) Finchingfield, Essex, England
Posted by clawson: Fri. Mar 31, 2006 - 11:15 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

GerryKeely wrote:
Leon
Programs simulates "correctly" without setting stack pointer
Gerry

I think the simulator often defaults the SP to RAMEND and while some of the modern AVRs do this in real life too I'm not sure that it's correctly simulating the behvaiour of some of the older AVRs.

Cliff

Top
gicutabacaru
gicutabacaru's picture
Level: New Member
Joined: Sun. Mar 19, 2006
Posts: 13 View posts
Location: ROU
Posted by gicutabacaru: Sat. Apr 1, 2006 - 04:01 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

it finaly worked,,you were right with the stack pointer,

thank you very much for help

Top