Reading multiple adc channels

Log in or register to post comments
Go To Last Post
5 posts / 0 new
Author
Message
djoshi
djoshi's picture
Level: Raving Lunatic
Joined: Tue. Dec 4, 2007
Posts: 3156 View posts
Location: UK London
#1
Posted by djoshi: Sun. Mar 29, 2020 - 07:02 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Hi All

 

I having some issues reading the voltage from two ADC channels. It seems like both channels are outputting the same value, where it should be different. This is my code.


void InitADC(void)
{
	//ADMUX=(1<<REFS0);                         // For Aref=2.5V;
	ADCSRA=(1<<ADEN)|(1<<ADPS2)|(1<<ADPS1)|(1<<ADPS0); //Rrescalar div factor =128
}

uint16_t ReadADC(uint8_t ch)
{
	ADMUX =0;
	ADMUX |=(1<<ch);
	//Start Single conversion
	ADCSRA|=(1<<ADSC);
	//Wait for conversion to complete
	while(!(ADCSRA & (1<<ADIF)));
	ADCSRA|=(1<<ADIF);
	uint16_t number = ((ADCH<< 8)|ADCL);			
	return(number);
}

I am then calling the following in my code

chA = ReadADC(1);
chB = ReadADC(2);

At fist i though i would need to clear ADMUX, which i am doing but it make no difference.

 

Please advice what i am doing wrong?

Thanks

Regards

DJ

Tags:

AVR Microcontrollers, megaAVR and tinyAVR
Last Edited: Sun. Mar 29, 2020 - 07:41 PM
Top
djoshi
djoshi's picture
Level: Raving Lunatic
Joined: Tue. Dec 4, 2007
Posts: 3156 View posts
Location: UK London
Posted by djoshi: Sun. Mar 29, 2020 - 07:04 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Sorry i am using the ATMEGA48PA, but it seems like i have posted this on wrong page. How can i change it?

Thanks

Regards

DJ

Top
Bronze Marktheusch
theusch's picture
Level: 10k+ Postman
Joined: Mon. Feb 19, 2001
Posts: 40013 View posts
Location: Wisconsin USA
Posted by theusch: Sun. Mar 29, 2020 - 09:19 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

How do you expect to get your desired reference voltage, when you clear ADMUX?

 

Are all Vcc and Gnd pais connected, including AVcc?

What voltage is on AVcc pin, RIGHT AT THE PIN?

What voltage is on AREF pin, RIGHT AT THE PIN?

What voltage is on PC1, RIGHT AT THE PIN?

What voltage is on PC2, RIGHT AT THE PIN?

What counts are you getting?

What counts do you expect?

You can put lipstick on a pig, but it is still a pig.

I've never met a pig I didn't like, as long as you have some salt and pepper.

Top
Kartman
Kartman's picture
Level: 10k+ Postman
Joined: Thu. Dec 30, 2004
Posts: 24796 View posts
Location: Melbourne,Australia
Posted by Kartman: Mon. Mar 30, 2020 - 03:24 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0
uint16_t ReadADC(uint8_t ch)
{

	ADMUX = ch | (1 << REFS0);
	//Start Single conversion
	ADCSRA|=(1<<ADSC);
	//Wait for conversion to complete
	while((ADCSRA & (1<<ADSC)));

    return ADC;
}

I dare say the root cause was your ADMUX |= (1<<ch);

It is not one bit per channel - it is an enumeration to select the input.

 

I have no idea why you would bother with the ADIF flag  except if your were using interrupts. Use the ADSC flag for what is was meant for.

Top
Gold Markclawson
clawson's picture
Level: Moderator
Joined: Mon. Jul 18, 2005
Posts: 101145 View posts
Location: (using avr-gcc in) Finchingfield, Essex, England
Posted by clawson: Mon. Mar 30, 2020 - 07:57 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 1

Note that in #4 Kartman changed:

	uint16_t number = ((ADCH<< 8)|ADCL);			
	return(number);

to be:

    return ADC;

this is also quite important. There is a dictated reading order for ADCL/ADCH and your original code may not achieve it (it's up to the compiler). But as Kartman's change also chose there's no need to deal with ADCL/ADCH separately anyway - the compiler provides "ADC" to red the whole thing (in the correct order) in one go.

Top