Patching avr-libc-1.7.0

Go To Last Post
3 posts / 0 new
Author
Message
#1
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Here is what I saw

===============================================================================


root:/sources/avr/make-avr-gcc/avr-libc-1.7.0# ls
AUTHORS		ChangeLog-2008	aclocal.m4	   config.h.in	 include
ChangeLog	ChangeLog-2009	avr		   config.sub	 install-sh
ChangeLog-2002	INSTALL		avr-libc.spec	   configure	 libc
ChangeLog-2003	LICENSE		avr-libc.spec.in   configure.ac  libm
ChangeLog-2004	Makefile.am	bootstrap	   crt1		 missing
ChangeLog-2005	Makefile.in	bug30363.v3.patch  depcomp	 scripts
ChangeLog-2006	NEWS		common		   devtools
ChangeLog-2007	README		config.guess	   doc
root:/sources/avr/make-avr-gcc/avr-libc-1.7.0# \
> patch -p0 < bug30363.v3.patch 
patching file include/util/delay.h.in
patching file ChangeLog
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file ChangeLog.rej
patching file NEWS
Hunk #1 FAILED at 147.
1 out of 1 hunk FAILED -- saving rejects to file NEWS.rej
root:/sources/avr/make-avr-gcc/avr-libc-1.7.0# cat ChangeLog.rej
***************
*** 1,3 ****
  2010-09-28  Anitha Boyapati
  
  	* include/avr/iotn88.h: Fix RAMEND.
--- 1,13 ----
+ 2010-10-13  Anitha Boyapati
+ 
+ 	* include/util/delay.h.in: Functions _delay_ms and 
+ 	_delay_us are modified. They now calculate new _ticks
+ 	value when builtin_avr_delay_cycle() is used. Macros
+ 	__DELAY_ROUND_DOWN__, __DELAY_ROUND_CLOSEST__ control
+ 	round up/closest of _ticks. __DELAY_BACKWARD_COMPATIBLE__
+ 	macro enables backward compatibility. This macro will be
+ 	deprecated.
+ 
  2010-09-28  Anitha Boyapati
  
  	* include/avr/iotn88.h: Fix RAMEND.
root:/sources/avr/make-avr-gcc/avr-libc-1.7.0# cat NEWS.rej
***************
*** 147,152 ****
    [#30669] Improve comment in stdiodemo
    [#30735] bug in example twitest
    [#31086] ATTINY88 RAMEND value not set to correct value in iotn88.h
  
  * Other changes:
  
--- 147,153 ----
    [#30669] Improve comment in stdiodemo
    [#30735] bug in example twitest
    [#31086] ATTINY88 RAMEND value not set to correct value in iotn88.h
+   [#30363] _delay_xx() functions in  are broken
  
  * Other changes:
  
root:/sources/avr/make-avr-gcc/avr-libc-1.7.0# 

Are these failed hunks only superficial?
Should I just carry on?

John

If all else fails, read the instructions.

  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Carry on. The failures are in two documentation files: ChangeLog and NEWS. Non of them affects the code.

If you are paranoid (you should), check if the patch was meant to be applied against your particular version. And check if the file that actually got patched (delay.h) looks reasonable now.

Stealing Proteus doesn't make you an engineer.

  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Thanks ArnoldB for giving me the encouragment to carry on.

The warnings have no effect.

The patch works fine.

Problems are over until the next release.

Many thanks Anitha for the patch.

John

If all else fails, read the instructions.