OK NO HELP I WONDER WHY THIS ISSDDADSSDASDC ANDDNOYING WRDJDLWEAMFDADWDD
Last Edited: Tue. Oct 6, 2020 - 11:47 AM
Memory handling for a simulated robot sensor
Author
Message
Why do you need to store all readings?
Don't you just want to keep track of the minimum value and the angle at which they occurred?
yes i do but im not sure how to do it without storing the values since i need to store and convert from string to float to read and compare them
Level: Moderator
Joined: Mon. Jul 18, 2005
Posts: 101127 View posts
Location: (using avr-gcc in) Finchingfield, Essex, England
String incomingByte = Serial.readString();
IRvalue[m] = incomingByte.toFloat();Two things:
1) incomingByte is a pretty dreadful name for this - it's not really a "byte" - it's a variable number of bytes.
2) Why do you need it inside the for() loop anyway. You just need one instance of incomingByte that you keep re-using. Once you have taken the float out of it simply clear it for next time ( incomingByte.clear() ), actually create it outside the for() loop.
Like Kartman I wonder why you store all the floats then look for min/max later ? You can do all that as you go along receiving the things. Same goes for testing below 25. Also as a reader of this code I have no idea what the significance of the value 25 us anyway. You might want to add a comment to tell the reader why that value and what units it is in perhaps?
SOLVED THANK BROTHER FROM THY OTHER MOTHER :)(dmeifnd
Last Edited: Tue. Oct 6, 2020 - 11:47 AM
Level: Moderator
Joined: Mon. Jul 18, 2005
Posts: 101127 View posts
Location: (using avr-gcc in) Finchingfield, Essex, England
jazzamate wrote:
The "Long work" is probably not the reception time - that is simply dictated by the baud rate and a handful of cycles to then collect the inbound bytes - it's probably the actual float conversion that takes a long time. Can't you get the "other end" to preprocess the data and send integer in the first place (if it's a more powerful PC it will take the heavy work away from the AVR). Better yet you might be able to send binary not ASCII so no ascii-to-float or even ascii-to-int conversion is needed at the AVR end at all.
Is there any better way of reading serial numbers quickly?
Why are you using float????? That seems a bit ridiculous or poor planning. Pay attention.
jazzamate wrote:
and serial.readstrings timeout function
You can reduce this with: https://www.arduino.cc/reference.... The timeout is only really useful if it's a human typing the characters. Or use: https://www.arduino.cc/reference...
Arduino String objects are trainer wheels. Horribly inefficient and memory hungry, but useful until you learn how do things 'properly' with chars and C-style char arrays.
Level: 10k+ Postman
Joined: Fri. Jul 1, 2005
Posts: 21408 View posts
Location: Basingstoke, Hampshire, UK
obdevel wrote:
Arduino String objects are trainer wheels.
they seem to be (somewhat) different from standard C++ strings: https://www.avrfreaks.net/commen... ?
Yes: https://github.com/arduino/Ardui...
There is some attempt to minimise memory reallocation and fragmentation, with a method to reserve a buffer: https://www.arduino.cc/reference...
Of course, it's easy to take potshots at Arduino and we should remember the original purpose and target audience for the project, regardless of how that has changed over the years.
I am a bit puzzled about what the OP means by "simulated robot sensor". Is the sensor simulated? Is the robot simulated? From the postings, it sound like there is real hardware, not simulated.
Jim