if statement not picking up on variable change

Log in or register to post comments
Go To Last Post
124 posts / 0 new
View All

Pages

Author
Message
jgmdesign
jgmdesign's picture
Level: Moderator
Joined: Mon. Mar 19, 2007
Posts: 17046 View posts
Location: Long Island New York
#1
Posted by jgmdesign: Wed. Mar 11, 2020 - 01:18 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

THis is for an XMEGA32E5 using Codevision.

 

I am trying to sense when a character has appeared in teh buffer - just a simple test - and echo it back. After snooping around I came across this thread:

 

https://www.avrfreaks.net/forum/...

 

Which is based on teh mega32 but its pretty much teh same code for the XMEGA.

 

I tried Davids suggestion of a #define like this:

#define DATARECEIVED() (rx_counter_usartc0 != 0)

and in the main loop:

void main(void)
{
  puts("Bite Me!");    //This PRINTS to SERIAL PORT

while (1)
      {
      if (DATARECEIVED()) putchar(getchar());  //This does nothing.  No output

      }; 
}

 

 

But there is no echo back.

 

I even tried this to see if it at least fires:

void main(void)
{
  puts("Bite Me!");    //This PRINTS to SERIAL PORT

while (1)
      {
      if(DATARECEIVED())
      {
	putchar('Y');  //Still does not print
     
      }

      } 
}

And still no output from teh serial port.

 

Very troubling

 

Jim

I would rather attempt something great and fail, than attempt nothing and succeed - Fortune Cookie

 

"The critical shortage here is not stuff, but time." - Johan Ekdahl

 

"Step N is required before you can do step N+1!" - ka7ehk

 

"If you want a career with a known path - become an undertaker. Dead people don't sue!" - Kartman

"Why is there a "Highway to Hell" and only a "Stairway to Heaven"? A prediction of the expected traffic load?"  - Lee "theusch"

 

Speak sweetly. It makes your words easier to digest when at a later date you have to eat them ;-)  - Source Unknown

Please Read: Code-of-Conduct

Atmel Studio6.2/AS7, DipTrace, Quartus, MPLAB, RSLogix user

Tags:

Tools, Compilers and General Programming
Top
theusch
theusch's picture
Level: 10k+ Postman
Joined: Mon. Feb 19, 2001
Posts: 39770 View posts
Location: Wisconsin USA
Posted by theusch: Wed. Mar 11, 2020 - 01:26 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Make a simple c0omplete program, and paste that.  The generated code for, at least, main().

 

So far, while your program is not signalling to your satisfaction, how do we know that

jgmdesign wrote:

rx_counter_usartc0

is NOT equal to 0?

 

For the signalling, do a simple put without the trigger -- do you see stuff on the TX?

You can put lipstick on a pig, but it is still a pig.

I've never met a pig I didn't like, as long as you have some salt and pepper.

Top
jgmdesign
jgmdesign's picture
Level: Moderator
Joined: Mon. Mar 19, 2007
Posts: 17046 View posts
Location: Long Island New York
Posted by jgmdesign: Wed. Mar 11, 2020 - 01:34 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Hey Lee!

 

theusch wrote:

So far, while your program is not signalling to your satisfaction, how do we know that

jgmdesign wrote:

 

rx_counter_usartc0

 

is NOT equal to 0?

 

From teh debug window:

 

It's not equal to zero.

 

theusch wrote:
For the signalling, do a simple put without the trigger -- do you see stuff on the TX?

Yes, I do.

 

Jim

I would rather attempt something great and fail, than attempt nothing and succeed - Fortune Cookie

 

"The critical shortage here is not stuff, but time." - Johan Ekdahl

 

"Step N is required before you can do step N+1!" - ka7ehk

 

"If you want a career with a known path - become an undertaker. Dead people don't sue!" - Kartman

"Why is there a "Highway to Hell" and only a "Stairway to Heaven"? A prediction of the expected traffic load?"  - Lee "theusch"

 

Speak sweetly. It makes your words easier to digest when at a later date you have to eat them ;-)  - Source Unknown

Please Read: Code-of-Conduct

Atmel Studio6.2/AS7, DipTrace, Quartus, MPLAB, RSLogix user

Top
Chuck99
Chuck99's picture
Level: Posting Freak
Joined: Sat. Oct 31, 2009
Posts: 1444 View posts
Location: Vancouver, WA, USA
Posted by Chuck99: Wed. Mar 11, 2020 - 01:42 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 1

Is rx_counter_usartc0 modified in an ISR?

Is it declared as voloatile?

Top
jgmdesign
jgmdesign's picture
Level: Moderator
Joined: Mon. Mar 19, 2007
Posts: 17046 View posts
Location: Long Island New York
Posted by jgmdesign: Wed. Mar 11, 2020 - 01:45 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Chuck99 wrote:

Is rx_counter_usartc0 modified in an ISR?

Is it declared as voloatile?

 

YEs.  From the .h file:

#ifndef _USARTS_INIT_INCLUDED_
#define _USARTS_INIT_INCLUDED_

// Disable an USART
void usart_disable(USART_t *pu);
// USARTC0 is used as the default input device by the 'getchar' function
// #define _ALTERNATE_GETCHAR_ is inserted for this purpose
// in the main program source file before #include <stdio.h>
char getchar(void);
// USARTC0 is used as the default output device by the 'putchar' function
// #define _ALTERNATE_PUTCHAR_ is inserted for this purpose
// in the main program source file before #include <stdio.h>
void putchar(char c);
// USARTC0 initialization
void usartc0_init(void);
// USARTC0 Receiver buffer
#define RX_BUFFER_SIZE_USARTC0 24

extern char rx_buffer_usartc0[RX_BUFFER_SIZE_USARTC0];
extern volatile unsigned char usartc0_eol;

#if RX_BUFFER_SIZE_USARTC0 <= 256
extern volatile unsigned char rx_wr_index_usartc0,rx_rd_index_usartc0;
#else
extern volatile unsigned int rx_wr_index_usartc0,rx_rd_index_usartc0;
#endif

#if RX_BUFFER_SIZE_USARTC0 < 256
extern volatile unsigned char rx_counter_usartc0;
#else
extern volatile unsigned int rx_counter_usartc0;
#endif

// This flag is set on USARTC0 Receiver buffer overflow
extern bit rx_buffer_overflow_usartc0;
// USARTC0 Transmitter buffer
#define TX_BUFFER_SIZE_USARTC0 128
extern char tx_buffer_usartc0[TX_BUFFER_SIZE_USARTC0];

#if TX_BUFFER_SIZE_USARTC0 <= 256
extern volatile unsigned char tx_wr_index_usartc0,tx_rd_index_usartc0;
#else
extern volatile unsigned int tx_wr_index_usartc0,tx_rd_index_usartc0;
#endif

#if TX_BUFFER_SIZE_USARTC0 < 256
extern volatile unsigned char tx_counter_usartc0;
#else
extern volatile unsigned int tx_counter_usartc0;
#endif

#endif

Jim

I would rather attempt something great and fail, than attempt nothing and succeed - Fortune Cookie

 

"The critical shortage here is not stuff, but time." - Johan Ekdahl

 

"Step N is required before you can do step N+1!" - ka7ehk

 

"If you want a career with a known path - become an undertaker. Dead people don't sue!" - Kartman

"Why is there a "Highway to Hell" and only a "Stairway to Heaven"? A prediction of the expected traffic load?"  - Lee "theusch"

 

Speak sweetly. It makes your words easier to digest when at a later date you have to eat them ;-)  - Source Unknown

Please Read: Code-of-Conduct

Atmel Studio6.2/AS7, DipTrace, Quartus, MPLAB, RSLogix user

Top
jgmdesign
jgmdesign's picture
Level: Moderator
Joined: Mon. Mar 19, 2007
Posts: 17046 View posts
Location: Long Island New York
Posted by jgmdesign: Wed. Mar 11, 2020 - 01:47 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Here is the main file contents:

/*******************************************************
This program was created by the CodeWizardAVR V3.38
Automatic Program Generator
© Copyright 1998-2019 Pavel Haiduc, HP InfoTech s.r.l.
http://www.hpinfotech.com

Project :
Version :
Date    : 3/10/2020
Author  :
Company :
Comments: 

Chip type               : ATxmega32E5
Program type            : Application
AVR Core Clock frequency: 11.059200 MHz
Memory model            : Small
Data Stack size         : 1024
*******************************************************/

// I/O Registers definitions
#include <xmega32e5.h>
#include <delay.h>
// USARTC0 is used as the default input
// device by the 'getchar' function.
#define _ALTERNATE_GETCHAR_
// USARTC0 is used as the default output
// device by the 'putchar' function.
#define _ALTERNATE_PUTCHAR_
// Standard Input/Output functions
#define DATARECEIVED()  (rx_counter_usartc0 != 0)
//indicates data ready to read
#include <stdio.h>

// Clock System initialization function
#include "clock_init.h"

// Event System initialization function
#include "event_system_init.h"

// I/O Ports initialization function
#include "ports_init.h"

// Timers/Counters initialization functions
#include "timers_init.h"

// RTC initialization function
#include "rtc_init.h"

// Watchdog Timer initialization function
#include "watchdog_init.h"

// USARTs initialization functions
#include "usarts_init.h"

// ADC initialization functions
#include "adc_init.h"

// Analog Comparator(s) initialization function(s)
#include "analog_comp_init.h"

// SPI initialization functions
#include "spi_init.h"

// TWI initialization functions
#include "twi_init.h"

// Declare your global variables here

void main(void)
{
// Declare your local variables here
unsigned char n;

// Interrupt system initialization
// Optimize for speed
#pragma optsize-
// Make sure the interrupts are disabled
#asm("cli")
// Low level interrupt: On
// Round-robin scheduling for low level interrupt: On
// Medium level interrupt: Off
// High level interrupt: Off
// The interrupt vectors will be placed at the start of the Application FLASH section
n=(PMIC.CTRL & (~(PMIC_RREN_bm | PMIC_IVSEL_bm | PMIC_HILVLEN_bm | PMIC_MEDLVLEN_bm | PMIC_LOLVLEN_bm))) |
	PMIC_LOLVLEN_bm | PMIC_RREN_bm;
CCP=CCP_IOREG_gc;
PMIC.CTRL=n;
// Set the default priority for round-robin scheduling
PMIC.INTPRI=0x00;
// Restore optimization for size if needed
#pragma optsize_default

// Watchdog timer initialization
watchdog_init();

// System clocks initialization
system_clocks_init();

// Event system initialization
event_system_init();

// Ports initialization
ports_init();

// Timer/Counter TCC4 initialization
tcc4_init();

// Timer/Counter TCC5 is disabled
tc5_disable(&TCC5);

// Timer/Counter TCD5 is disabled
tc5_disable(&TCD5);

// RTC initialization
rtcxm_init();

// USARTC0 initialization
usartc0_init();

// USARTD0 is disabled
usart_disable(&USARTD0);

// SPIC initialization
spic_init();

// TWIC initialization
twic_init();

// ADCA initialization
adca_init();

// DACA is disabled
DACA.CTRLA=0;

// Analog Comparator(s) for PORTA initialization
aca_init();

// Globally enable interrupts
#asm("sei")

puts("Bite Me!");

while (1)
      { 

	if (DATARECEIVED()) putchar(getchar());  //This does nothing.  No output
      }

}

Jim

I would rather attempt something great and fail, than attempt nothing and succeed - Fortune Cookie

 

"The critical shortage here is not stuff, but time." - Johan Ekdahl

 

"Step N is required before you can do step N+1!" - ka7ehk

 

"If you want a career with a known path - become an undertaker. Dead people don't sue!" - Kartman

"Why is there a "Highway to Hell" and only a "Stairway to Heaven"? A prediction of the expected traffic load?"  - Lee "theusch"

 

Speak sweetly. It makes your words easier to digest when at a later date you have to eat them ;-)  - Source Unknown

Please Read: Code-of-Conduct

Atmel Studio6.2/AS7, DipTrace, Quartus, MPLAB, RSLogix user

Top
jgmdesign
jgmdesign's picture
Level: Moderator
Joined: Mon. Mar 19, 2007
Posts: 17046 View posts
Location: Long Island New York
Posted by jgmdesign: Wed. Mar 11, 2020 - 02:07 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

theusch wrote:
The generated code for, at least, main().

Lee are you looking for the source, or teh compiled assembly code?

 

JIm

I would rather attempt something great and fail, than attempt nothing and succeed - Fortune Cookie

 

"The critical shortage here is not stuff, but time." - Johan Ekdahl

 

"Step N is required before you can do step N+1!" - ka7ehk

 

"If you want a career with a known path - become an undertaker. Dead people don't sue!" - Kartman

"Why is there a "Highway to Hell" and only a "Stairway to Heaven"? A prediction of the expected traffic load?"  - Lee "theusch"

 

Speak sweetly. It makes your words easier to digest when at a later date you have to eat them ;-)  - Source Unknown

Please Read: Code-of-Conduct

Atmel Studio6.2/AS7, DipTrace, Quartus, MPLAB, RSLogix user

Top
jgmdesign
jgmdesign's picture
Level: Moderator
Joined: Mon. Mar 19, 2007
Posts: 17046 View posts
Location: Long Island New York
Posted by jgmdesign: Wed. Mar 11, 2020 - 02:58 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Well, it's late and I am getting tired.  Not sure why the code is ignoring the USART variables which are declared volatile, and I can see in the watch window.

 

Attachment removed - jgm

 

Jim

I would rather attempt something great and fail, than attempt nothing and succeed - Fortune Cookie

 

"The critical shortage here is not stuff, but time." - Johan Ekdahl

 

"Step N is required before you can do step N+1!" - ka7ehk

 

"If you want a career with a known path - become an undertaker. Dead people don't sue!" - Kartman

"Why is there a "Highway to Hell" and only a "Stairway to Heaven"? A prediction of the expected traffic load?"  - Lee "theusch"

 

Speak sweetly. It makes your words easier to digest when at a later date you have to eat them ;-)  - Source Unknown

Please Read: Code-of-Conduct

Atmel Studio6.2/AS7, DipTrace, Quartus, MPLAB, RSLogix user

Last Edited: Wed. Mar 11, 2020 - 10:42 AM
Top
clawson
clawson's picture
Level: Moderator
Joined: Mon. Jul 18, 2005
Posts: 99277 View posts
Location: (using avr-gcc in) Finchingfield, Essex, England
Posted by clawson: Wed. Mar 11, 2020 - 10:34 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 1

jgmdesign wrote:
why the code is ignoring
Does the Asm really show no access to the variable locations in question? (AFAICS that's the only way it could be "ignored"). Or are you saying that after access it is not performing the right data comparison? Again this should all be visible in the Asm.

Top
jgmdesign
jgmdesign's picture
Level: Moderator
Joined: Mon. Mar 19, 2007
Posts: 17046 View posts
Location: Long Island New York
Posted by jgmdesign: Wed. Mar 11, 2020 - 11:28 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

clawson wrote:

Does the Asm really show no access to the variable locations in question? (AFAICS that's the only way it could be "ignored"). Or are you saying that after access it is not performing the right data comparison? Again this should all be visible in the Asm.

Its not performing the right data comparison.

 

jgmdesign wrote:

if (DATARECEIVED()) putchar(getchar());

Never fires.  I have also tried:

if(rx_counter_usartc0 != 0) putchar(getchar());

I'll pull the ASM and see what it reads.

 

Thanks

Jim

I would rather attempt something great and fail, than attempt nothing and succeed - Fortune Cookie

 

"The critical shortage here is not stuff, but time." - Johan Ekdahl

 

"Step N is required before you can do step N+1!" - ka7ehk

 

"If you want a career with a known path - become an undertaker. Dead people don't sue!" - Kartman

"Why is there a "Highway to Hell" and only a "Stairway to Heaven"? A prediction of the expected traffic load?"  - Lee "theusch"

 

Speak sweetly. It makes your words easier to digest when at a later date you have to eat them ;-)  - Source Unknown

Please Read: Code-of-Conduct

Atmel Studio6.2/AS7, DipTrace, Quartus, MPLAB, RSLogix user

Top
jgmdesign
jgmdesign's picture
Level: Moderator
Joined: Mon. Mar 19, 2007
Posts: 17046 View posts
Location: Long Island New York
Posted by jgmdesign: Wed. Mar 11, 2020 - 11:38 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Here is the ASM code:

                 _0x4:
                 ; 0000 0094       {
                 ; 0000 0095        if (DATARECEIVED()) putchar(getchar());  //This does nothing.  No output
0000bf 91e0 2423 	LDS  R30,_rx_counter_usartc0
0000c1 30e0      	CPI  R30,0
0000c2 f019      	BREQ _0x7
0000c3 d1bf      	RCALL _getchar
0000c4 2fae      	MOV  R26,R30
0000c5 d203      	RCALL _putchar
                 ; 0000 0096 
                 ; 0000 0097 
                 ; 0000 0098       }
                 _0x7:
0000c6 cff8      	RJMP _0x4
                 ; 0000 0099 }
                 _0x8:
0000c7 cfff      	RJMP _0x8
                 ; .FEND

it looks like it's right.

I would rather attempt something great and fail, than attempt nothing and succeed - Fortune Cookie

 

"The critical shortage here is not stuff, but time." - Johan Ekdahl

 

"Step N is required before you can do step N+1!" - ka7ehk

 

"If you want a career with a known path - become an undertaker. Dead people don't sue!" - Kartman

"Why is there a "Highway to Hell" and only a "Stairway to Heaven"? A prediction of the expected traffic load?"  - Lee "theusch"

 

Speak sweetly. It makes your words easier to digest when at a later date you have to eat them ;-)  - Source Unknown

Please Read: Code-of-Conduct

Atmel Studio6.2/AS7, DipTrace, Quartus, MPLAB, RSLogix user

Top
clawson
clawson's picture
Level: Moderator
Joined: Mon. Jul 18, 2005
Posts: 99277 View posts
Location: (using avr-gcc in) Finchingfield, Essex, England
Posted by clawson: Wed. Mar 11, 2020 - 11:44 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

So the implication then is that rx_counter_usartc0 does contain 0x00 when this line is encountered (or getchar is not returning something that is printable?)

 

If you actually put a breakpoint on 00BF and single step what happens, what is in R30 at the time ?

Top
jgmdesign
jgmdesign's picture
Level: Moderator
Joined: Mon. Mar 19, 2007
Posts: 17046 View posts
Location: Long Island New York
Posted by jgmdesign: Wed. Mar 11, 2020 - 12:00 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

clawson wrote:

So the implication then is that rx_counter_usartc0 does contain 0x00 when this line is encountered (or getchar is not returning something that is printable?)

 

No, take a look at Post #3.  I will send a few characters from my terminal to increment rx_counter_usartc0, which should trigger the IF statement.  I showed the Watch window that shows that rx_counter_usartc0 is NOT zero which should satisfy the IF statement.

 

Getchar() is not printing what is in the buffer - which I can see has the characters I typed in teh terminal.

 

JIm

I would rather attempt something great and fail, than attempt nothing and succeed - Fortune Cookie

 

"The critical shortage here is not stuff, but time." - Johan Ekdahl

 

"Step N is required before you can do step N+1!" - ka7ehk

 

"If you want a career with a known path - become an undertaker. Dead people don't sue!" - Kartman

"Why is there a "Highway to Hell" and only a "Stairway to Heaven"? A prediction of the expected traffic load?"  - Lee "theusch"

 

Speak sweetly. It makes your words easier to digest when at a later date you have to eat them ;-)  - Source Unknown

Please Read: Code-of-Conduct

Atmel Studio6.2/AS7, DipTrace, Quartus, MPLAB, RSLogix user

Top
frog_jr
frog_jr's picture
Level: Posting Freak
Joined: Sat. Jan 15, 2011
Posts: 1929 View posts
Location: Woodway, Texas
Posted by frog_jr: Wed. Mar 11, 2020 - 12:22 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Is rx_counter_usartc0 declared and initialized within a .c file?

David (aka frog_jr)

Top
jgmdesign
jgmdesign's picture
Level: Moderator
Joined: Mon. Mar 19, 2007
Posts: 17046 View posts
Location: Long Island New York
Posted by jgmdesign: Wed. Mar 11, 2020 - 12:25 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

frog_jr wrote:

Is rx_counter_usartc0 declared and initialized within a .c file?

Yes,


#if RX_BUFFER_SIZE_USARTC0 < 256
volatile unsigned char rx_counter_usartc0=0;
#else
volatile unsigned int rx_counter_usartc0=0;
#endif

 

in the usarts_init.c file

 

and in the usarts.init.h we have:


#if RX_BUFFER_SIZE_USARTC0 < 256
extern volatile unsigned char rx_counter_usartc0;
#else
extern volatile unsigned int rx_counter_usartc0;
#endif

 

 

THis is what has me scratching my head.  CV wizard looks to have set everything up properly.

 

Jim

I would rather attempt something great and fail, than attempt nothing and succeed - Fortune Cookie

 

"The critical shortage here is not stuff, but time." - Johan Ekdahl

 

"Step N is required before you can do step N+1!" - ka7ehk

 

"If you want a career with a known path - become an undertaker. Dead people don't sue!" - Kartman

"Why is there a "Highway to Hell" and only a "Stairway to Heaven"? A prediction of the expected traffic load?"  - Lee "theusch"

 

Speak sweetly. It makes your words easier to digest when at a later date you have to eat them ;-)  - Source Unknown

Please Read: Code-of-Conduct

Atmel Studio6.2/AS7, DipTrace, Quartus, MPLAB, RSLogix user

Top
clawson
clawson's picture
Level: Moderator
Joined: Mon. Jul 18, 2005
Posts: 99277 View posts
Location: (using avr-gcc in) Finchingfield, Essex, England
Posted by clawson: Wed. Mar 11, 2020 - 01:02 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

clawson wrote:
If you actually put a breakpoint on 00BF and single step what happens, what is in R30 at the time ?

Top
jgmdesign
jgmdesign's picture
Level: Moderator
Joined: Mon. Mar 19, 2007
Posts: 17046 View posts
Location: Long Island New York
Posted by jgmdesign: Wed. Mar 11, 2020 - 01:22 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Cliff,

Not to sound ignorant, but I have never done what you are asking, but I opened the .asm file and put the breakpoint on:

 

LDS  R30,_rx_counter_usartc0

and ran the code (its an Atmel ICE connected to my STK600 with an actual x32E5 on board so its real hardware).  I typed a few characters on my keyboard and the breakpoint does not fire, nor can I single step.  The 'rx_counter_usartc0' does indeed increment as it shows in teh watch window though.  R30 still shows 0x00 so its like the variable is not being looked at.

 

This is very frustrating.

 

JIm

I would rather attempt something great and fail, than attempt nothing and succeed - Fortune Cookie

 

"The critical shortage here is not stuff, but time." - Johan Ekdahl

 

"Step N is required before you can do step N+1!" - ka7ehk

 

"If you want a career with a known path - become an undertaker. Dead people don't sue!" - Kartman

"Why is there a "Highway to Hell" and only a "Stairway to Heaven"? A prediction of the expected traffic load?"  - Lee "theusch"

 

Speak sweetly. It makes your words easier to digest when at a later date you have to eat them ;-)  - Source Unknown

Please Read: Code-of-Conduct

Atmel Studio6.2/AS7, DipTrace, Quartus, MPLAB, RSLogix user

Top
ki0bk
ki0bk's picture
Level: Raving Lunatic
Joined: Mon. Sep 8, 2014
Posts: 7044 View posts
Location: Olathe KS
Posted by ki0bk: Wed. Mar 11, 2020 - 01:24 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Time to post a small complete program for the Freaks can take a detailed look Jim!

 

Jim

 

 

 

 

Top
jgmdesign
jgmdesign's picture
Level: Moderator
Joined: Mon. Mar 19, 2007
Posts: 17046 View posts
Location: Long Island New York
Posted by jgmdesign: Wed. Mar 11, 2020 - 01:32 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

ki0bk wrote:

Time to post a small complete program for the Freaks can take a detailed look Jim!

 

Jim

Here is the main file:

/*******************************************************
This program was created by the CodeWizardAVR V3.38 
Automatic Program Generator
© Copyright 1998-2019 Pavel Haiduc, HP InfoTech s.r.l.
http://www.hpinfotech.com

Project : 
Version : 
Date    : 3/10/2020
Author  : 
Company : 
Comments: 


Chip type               : ATxmega32E5
Program type            : Application
AVR Core Clock frequency: 11.059200 MHz
Memory model            : Small
Data Stack size         : 1024
*******************************************************/

// I/O Registers definitions
#include <xmega32e5.h>

// USARTC0 is used as the default input
// device by the 'getchar' function.
#define _ALTERNATE_GETCHAR_
// USARTC0 is used as the default output
// device by the 'putchar' function.
#define _ALTERNATE_PUTCHAR_
//macro for picking up data received
#define DATARECEIVED() (rx_counter_usartc0 != 0)
// Standard Input/Output functions
#include <delay.h>
#include <stdio.h>

// Clock System initialization function
#include "clock_init.h"

// Event System initialization function
#include "event_system_init.h"

// I/O Ports initialization function
#include "ports_init.h"

// Timers/Counters initialization functions
#include "timers_init.h"

// RTC initialization function
#include "rtc_init.h"

// Watchdog Timer initialization function
#include "watchdog_init.h"

// USARTs initialization functions
#include "usarts_init.h"

// ADC initialization functions
#include "adc_init.h"

// Analog Comparator(s) initialization function(s)
#include "analog_comp_init.h"

// SPI initialization functions
#include "spi_init.h"

// TWI initialization functions
#include "twi_init.h"

// Declare your global variables here

void main(void)
{
// Declare your local variables here
unsigned char n;
int j = 1;
// Interrupt system initialization
// Optimize for speed
#pragma optsize- 
// Make sure the interrupts are disabled
#asm("cli")
// Low level interrupt: On
// Round-robin scheduling for low level interrupt: On
// Medium level interrupt: Off
// High level interrupt: Off
// The interrupt vectors will be placed at the start of the Application FLASH section
n=(PMIC.CTRL & (~(PMIC_RREN_bm | PMIC_IVSEL_bm | PMIC_HILVLEN_bm | PMIC_MEDLVLEN_bm | PMIC_LOLVLEN_bm))) |
	PMIC_LOLVLEN_bm | PMIC_RREN_bm;
CCP=CCP_IOREG_gc;
PMIC.CTRL=n;
// Set the default priority for round-robin scheduling
PMIC.INTPRI=0x00;
// Restore optimization for size if needed
#pragma optsize_default

// Watchdog timer initialization
watchdog_init();

// System clocks initialization
system_clocks_init();

// Event system initialization
event_system_init();

// Ports initialization
ports_init();

// Timer/Counter TCC4 initialization
tcc4_init();

// Timer/Counter TCC5 is disabled
tc5_disable(&TCC5);

// Timer/Counter TCD5 initialization
tcd5_init();

// RTC initialization
rtcxm_init();

// USARTC0 initialization
usartc0_init();

// USARTD0 is disabled
usart_disable(&USARTD0);

// SPIC initialization
spic_init();

// TWIC initialization
twic_init();

// ADCA initialization
adca_init();

// DACA is disabled
DACA.CTRLA=0;

// Analog Comparator(s) for PORTA initialization
aca_init();

// Globally enable interrupts
#asm("sei")

puts("BITE ME!");   //This PRINTS to SERIAL PORT



while (1)
      {
         if (DATARECEIVED()) putchar(getchar());  //This does nothing.  No output
	   
		

      }
}

Here is the USARSts_init.h file:

/*******************************************************
USARTs initialization created by the
CodeWizardAVR V3.38 Automatic Program Generator
© Copyright 1998-2019 Pavel Haiduc, HP InfoTech s.r.l.
http://www.hpinfotech.com

Project : 
*******************************************************/

#ifndef _USARTS_INIT_INCLUDED_
#define _USARTS_INIT_INCLUDED_

// Disable an USART
void usart_disable(USART_t *pu);
// USARTC0 is used as the default input device by the 'getchar' function
// #define _ALTERNATE_GETCHAR_ is inserted for this purpose
// in the main program source file before #include <stdio.h>
char getchar(void);
// USARTC0 is used as the default output device by the 'putchar' function
// #define _ALTERNATE_PUTCHAR_ is inserted for this purpose
// in the main program source file before #include <stdio.h>
void putchar(char c);
// USARTC0 initialization
void usartc0_init(void);
// USARTC0 Receiver buffer
#define RX_BUFFER_SIZE_USARTC0 24
extern char rx_buffer_usartc0[RX_BUFFER_SIZE_USARTC0];


#if RX_BUFFER_SIZE_USARTC0 <= 256
extern volatile unsigned char rx_wr_index_usartc0,rx_rd_index_usartc0;
#else
extern volatile unsigned int rx_wr_index_usartc0,rx_rd_index_usartc0;
#endif

#if RX_BUFFER_SIZE_USARTC0 < 256
extern volatile unsigned char rx_counter_usartc0;
#else
extern volatile unsigned int rx_counter_usartc0;
#endif

// This flag is set on USARTC0 Receiver buffer overflow
extern bit rx_buffer_overflow_usartc0;
// USARTC0 Transmitter buffer
#define TX_BUFFER_SIZE_USARTC0 32
extern char tx_buffer_usartc0[TX_BUFFER_SIZE_USARTC0];

#if TX_BUFFER_SIZE_USARTC0 <= 256
extern volatile unsigned char tx_wr_index_usartc0,tx_rd_index_usartc0;
#else
extern volatile unsigned int tx_wr_index_usartc0,tx_rd_index_usartc0;
#endif

#if TX_BUFFER_SIZE_USARTC0 < 256
extern volatile unsigned char tx_counter_usartc0;
#else
extern volatile unsigned int tx_counter_usartc0;
#endif

#endif

And teh USARTS_INIT.c file:

/*******************************************************
USARTs initialization created by the
CodeWizardAVR V3.38 Automatic Program Generator
© Copyright 1998-2019 Pavel Haiduc, HP InfoTech s.r.l.
http://www.hpinfotech.com

Project : 
*******************************************************/

// I/O Registers definitions
#include <xmega32e5.h>

// USARTs initialization functions
#include "usarts_init.h"

// Disable an USART
void usart_disable(USART_t *pu)
{
// Rx and Tx are off
pu->CTRLB=0;
// Ensure that all interrupts generated by the USART are off
pu->CTRLA=0;
}

// USARTC0 initialization
void usartc0_init(void)
{
// Note: The correct PORTC direction for the RxD, TxD and XCK signals
// is configured in the ports_init function.

// Transmitter is enabled
// Set TxD=1
PORTC.OUTSET=0x08;

// Communication mode: Asynchronous USART
// Data bits: 8
// Stop bits: 1
// Parity: Disabled
USARTC0.CTRLC=USART_CMODE_ASYNCHRONOUS_gc | USART_PMODE_DISABLED_gc | USART_CHSIZE_8BIT_gc;

// Receive complete interrupt: Low Level
// Transmit complete interrupt: Low Level
// Data register empty interrupt: Disabled
USARTC0.CTRLA=(USARTC0.CTRLA & (~(USART_RXCINTLVL_gm | USART_TXCINTLVL_gm | USART_DREINTLVL_gm))) |
	USART_RXCINTLVL_LO_gc | USART_TXCINTLVL_LO_gc | USART_DREINTLVL_OFF_gc;

// Required Baud rate: 115200
// Real Baud Rate: 115200.0 (x1 Mode), Error: 0.0 %
USARTC0.BAUDCTRLA=0x80;
USARTC0.BAUDCTRLB=((0x09 << USART_BSCALE_gp) & USART_BSCALE_gm) | 0x02;

// Receiver: On
// Transmitter: On
// Double transmission speed mode: Off
// Multi-processor communication mode: Off
USARTC0.CTRLB=(USARTC0.CTRLB & (~(USART_RXEN_bm | USART_TXEN_bm | USART_CLK2X_bm | USART_MPCM_bm | USART_TXB8_bm))) |
	USART_RXEN_bm | USART_TXEN_bm;
}

// Note: RX_BUFFER_SIZE_USARTC0 is #define-d in 'usarts_init.h' with the value 24
char rx_buffer_usartc0[RX_BUFFER_SIZE_USARTC0];

#if RX_BUFFER_SIZE_USARTC0 <= 256
volatile unsigned char rx_wr_index_usartc0=0,rx_rd_index_usartc0=0;
#else
volatile unsigned int rx_wr_index_usartc0=0,rx_rd_index_usartc0=0;
#endif

#if RX_BUFFER_SIZE_USARTC0 < 256
volatile unsigned char rx_counter_usartc0=0;
#else
volatile unsigned int rx_counter_usartc0=0;
#endif

// This flag is set on USARTC0 Receiver buffer overflow
bit rx_buffer_overflow_usartc0=0;

// USARTC0 Receiver interrupt service routine
interrupt [USARTC0_RXC_vect] void usartc0_rx_isr(void)
{
unsigned char status;
char data;

status=USARTC0.STATUS;
data=USARTC0.DATA;
if ((status & (USART_FERR_bm | USART_PERR_bm | USART_BUFOVF_bm)) == 0)
   {
   rx_buffer_usartc0[rx_wr_index_usartc0++]=data;
   
#if RX_BUFFER_SIZE_USARTC0 == 256
   // special case for receiver buffer size=256
   if (++rx_counter_usartc0 == 0) rx_buffer_overflow_usartc0=1;
#else
   if (rx_wr_index_usartc0 == RX_BUFFER_SIZE_USARTC0) rx_wr_index_usartc0=0;
   if (++rx_counter_usartc0 == RX_BUFFER_SIZE_USARTC0)
      {
      rx_counter_usartc0=0;
      rx_buffer_overflow_usartc0=1;
      }
#endif
   }
}

// Receive a character from USARTC0
// USARTC0 is used as the default input device by the 'getchar' function
// #define _ALTERNATE_GETCHAR_ is inserted for this purpose
// in the main program source file before #include <stdio.h>
#pragma used+
char getchar(void)
{
char data;

while (rx_counter_usartc0==0);
data=rx_buffer_usartc0[rx_rd_index_usartc0++];
#if RX_BUFFER_SIZE_USARTC0 != 256
if (rx_rd_index_usartc0 == RX_BUFFER_SIZE_USARTC0) rx_rd_index_usartc0=0;
#endif
#asm("cli")
--rx_counter_usartc0;
#asm("sei")
return data;
}
#pragma used-

// Note: TX_BUFFER_SIZE_USARTC0 is #define-d in 'usarts_init.h' with the value 32
char tx_buffer_usartc0[TX_BUFFER_SIZE_USARTC0];

#if TX_BUFFER_SIZE_USARTC0 <= 256
volatile unsigned char tx_wr_index_usartc0=0,tx_rd_index_usartc0=0;
#else
volatile unsigned int tx_wr_index_usartc0=0,tx_rd_index_usartc0=0;
#endif

#if TX_BUFFER_SIZE_USARTC0 < 256
volatile unsigned char tx_counter_usartc0=0;
#else
volatile unsigned int tx_counter_usartc0=0;
#endif

// USARTC0 Transmitter interrupt service routine
interrupt [USARTC0_TXC_vect] void usartc0_tx_isr(void)
{
if (tx_counter_usartc0)
   {
   --tx_counter_usartc0;
   USARTC0.DATA=tx_buffer_usartc0[tx_rd_index_usartc0++];
#if TX_BUFFER_SIZE_USARTC0 != 256
   if (tx_rd_index_usartc0 == TX_BUFFER_SIZE_USARTC0) tx_rd_index_usartc0=0;
#endif
   }
}

// Write a character to the USARTC0 Transmitter buffer
// USARTC0 is used as the default output device by the 'putchar' function
// #define _ALTERNATE_PUTCHAR_ is inserted for this purpose
// in the main program source file before #include <stdio.h>
#pragma used+
void putchar(char c)
{
while (tx_counter_usartc0 == TX_BUFFER_SIZE_USARTC0);
#asm("cli")
if (tx_counter_usartc0 || ((USARTC0.STATUS & USART_DREIF_bm)==0))
   {
   tx_buffer_usartc0[tx_wr_index_usartc0++]=c;
#if TX_BUFFER_SIZE_USARTC0 != 256
   if (tx_wr_index_usartc0 == TX_BUFFER_SIZE_USARTC0) tx_wr_index_usartc0=0;
#endif
   ++tx_counter_usartc0;
   }
else
   USARTC0.DATA=c;
#asm("sei")
}
#pragma used-

JIm

I would rather attempt something great and fail, than attempt nothing and succeed - Fortune Cookie

 

"The critical shortage here is not stuff, but time." - Johan Ekdahl

 

"Step N is required before you can do step N+1!" - ka7ehk

 

"If you want a career with a known path - become an undertaker. Dead people don't sue!" - Kartman

"Why is there a "Highway to Hell" and only a "Stairway to Heaven"? A prediction of the expected traffic load?"  - Lee "theusch"

 

Speak sweetly. It makes your words easier to digest when at a later date you have to eat them ;-)  - Source Unknown

Please Read: Code-of-Conduct

Atmel Studio6.2/AS7, DipTrace, Quartus, MPLAB, RSLogix user

Top
clawson
clawson's picture
Level: Moderator
Joined: Mon. Jul 18, 2005
Posts: 99277 View posts
Location: (using avr-gcc in) Finchingfield, Essex, England
Posted by clawson: Wed. Mar 11, 2020 - 01:36 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

If it doesn't hit the break on that then it's simply never getting as far as the if() in the first place. So something before this is either blocking or skipping it.

 

I take it the puts("Bit me") is seen to execute ?

 

I wonder if it's swamped in ISRs ?? I know ISR return allows one opcode from main() to execute each time so eventually it should execute everything in the while(1) but perhaps it is taking a very long time ?

Top
jgmdesign
jgmdesign's picture
Level: Moderator
Joined: Mon. Mar 19, 2007
Posts: 17046 View posts
Location: Long Island New York
Posted by jgmdesign: Wed. Mar 11, 2020 - 01:46 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

clawson wrote:

If it doesn't hit the break on that then it's simply never getting as far as the if() in the first place. So something before this is either blocking or skipping it.

 

I take it the puts("Bit me") is seen to execute ?

 

I wonder if it's swamped in ISRs ?? I know ISR return allows one opcode from main() to execute each time so eventually it should execute everything in the while(1) but perhaps it is taking a very long time ?

 

Ok, heres an update that might have some meat on it....

 

clawson wrote:
I take it the puts("Bit me") is seen to execute ?

Yes, BITE ME! prints.

 

clawson wrote:
If it doesn't hit the break on that then it's simply never getting as far as the if() in the first place. So something before this is either blocking or skipping it.

When I hit RUN and do nothing for a few seconds then hit PAUSE the window shows that the application is sitting in this spot:

while (rx_counter_usartc0==0);

which is a problem because at application launch, "rx_counter_usartc0" will be zero so the program is just sitting there meaning that the code is stuck and if I had anything else running it wont until a character is received...which is not constant...maybe once every 30 minutes or so something will come in.

 

Ok, so I type a character (the letter 'c') and then hit PAUSE and now 'rx_counter_usartc0' is at 0x01, R30 has 0x63 (the hexadecimal number for 'c' and R28 has the number 0x01 in it?!  WTH?

 

But even though R30 does not have the number I would think should be there, it is not equal to zero so the if statement should execute.

 

Grrr....

 

JIm

I would rather attempt something great and fail, than attempt nothing and succeed - Fortune Cookie

 

"The critical shortage here is not stuff, but time." - Johan Ekdahl

 

"Step N is required before you can do step N+1!" - ka7ehk

 

"If you want a career with a known path - become an undertaker. Dead people don't sue!" - Kartman

"Why is there a "Highway to Hell" and only a "Stairway to Heaven"? A prediction of the expected traffic load?"  - Lee "theusch"

 

Speak sweetly. It makes your words easier to digest when at a later date you have to eat them ;-)  - Source Unknown

Please Read: Code-of-Conduct

Atmel Studio6.2/AS7, DipTrace, Quartus, MPLAB, RSLogix user

Top
clawson
clawson's picture
Level: Moderator
Joined: Mon. Jul 18, 2005
Posts: 99277 View posts
Location: (using avr-gcc in) Finchingfield, Essex, England
Posted by clawson: Wed. Mar 11, 2020 - 02:04 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

jgmdesign wrote:
which is a problem because at application launch, "rx_counter_usartc0" will be zero so the program is just sitting there meaning that the code is stuck and if I had anything else running it wont until a character is received...which is not constant...maybe once every 30 minutes or so something will come in.
So what is the code behind THAT line? As rx_counter_usartc0 must be "volatile" then the code should be something like:

while_wait:
    LDS R24, rx_counter_c0
    OR R24, R24
    BRNE carry_on
    RJMP while_wait
carry_on:

if the loop does not contain LD or LDS or whatever to actually keep re-reading the volatile then that would be a bit of a problem !

Top
jgmdesign
jgmdesign's picture
Level: Moderator
Joined: Mon. Mar 19, 2007
Posts: 17046 View posts
Location: Long Island New York
Posted by jgmdesign: Wed. Mar 11, 2020 - 02:14 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Cliff,

I pulled the entire ASM for the USART.  I am no expert, but it looks like the getchar() function is missing:

;/*******************************************************
;USARTs initialization created by the
;CodeWizardAVR V3.38 Automatic Program Generator
;© Copyright 1998-2019 Pavel Haiduc, HP InfoTech s.r.l.
;http://www.hpinfotech.com
;
;Project :
;*******************************************************/
;
;// I/O Registers definitions
;#include <xmega32e5.h>
;
;// USARTs initialization functions
;#include "usarts_init.h"
;
;// Disable an USART
;void usart_disable(USART_t *pu)
; 0007 0012 {

	.CSEG
_usart_disable:
; .FSTART _usart_disable
; 0007 0013 // Rx and Tx are off
; 0007 0014 pu->CTRLB=0;
	ST   -Y,R17
	ST   -Y,R16
	MOVW R16,R26
;	*pu -> R16,R17
	ADIW R26,3
	LDI  R30,LOW(0)
	ST   X,R30
; 0007 0015 // Ensure that all interrupts generated by the USART are off
; 0007 0016 pu->CTRLA=0;
	MOVW R26,R16
	ADIW R26,2
_0x2080004:
	ST   X,R30
; 0007 0017 }
_0x2080003:
	LD   R16,Y+
	LD   R17,Y+
	RET
; .FEND
;
;// USARTC0 initialization
;void usartc0_init(void)
; 0007 001B {
_usartc0_init:
; .FSTART _usartc0_init
; 0007 001C // Note: The correct PORTC direction for the RxD, TxD and XCK signals
; 0007 001D // is configured in the ports_init function.
; 0007 001E 
; 0007 001F // Transmitter is enabled
; 0007 0020 // Set TxD=1
; 0007 0021 PORTC.OUTSET=0x08;
	LDI  R30,LOW(8)
	STS  1605,R30
; 0007 0022 
; 0007 0023 // Communication mode: Asynchronous USART
; 0007 0024 // Data bits: 8
; 0007 0025 // Stop bits: 1
; 0007 0026 // Parity: Disabled
; 0007 0027 USARTC0.CTRLC=USART_CMODE_ASYNCHRONOUS_gc | USART_PMODE_DISABLED_gc | USART_CHSIZE_8BIT_gc;
	LDI  R30,LOW(3)
	STS  2244,R30
; 0007 0028 
; 0007 0029 // Receive complete interrupt: Low Level
; 0007 002A // Transmit complete interrupt: Low Level
; 0007 002B // Data register empty interrupt: Disabled
; 0007 002C USARTC0.CTRLA=(USARTC0.CTRLA & (~(USART_RXCINTLVL_gm | USART_TXCINTLVL_gm | USART_DREINTLVL_gm))) |
; 0007 002D 	USART_RXCINTLVL_LO_gc | USART_TXCINTLVL_LO_gc | USART_DREINTLVL_OFF_gc;
	LDS  R30,2242
	ANDI R30,LOW(0xC0)
	ORI  R30,LOW(0x14)
	STS  2242,R30
; 0007 002E 
; 0007 002F // Required Baud rate: 115200
; 0007 0030 // Real Baud Rate: 115200.0 (x1 Mode), Error: 0.0 %
; 0007 0031 USARTC0.BAUDCTRLA=0x80;
	LDI  R30,LOW(128)
	STS  2246,R30
; 0007 0032 USARTC0.BAUDCTRLB=((0x09 << USART_BSCALE_gp) & USART_BSCALE_gm) | 0x02;
	LDI  R30,LOW(146)
	STS  2247,R30
; 0007 0033 
; 0007 0034 // Receiver: On
; 0007 0035 // Transmitter: On
; 0007 0036 // Double transmission speed mode: Off
; 0007 0037 // Multi-processor communication mode: Off
; 0007 0038 USARTC0.CTRLB=(USARTC0.CTRLB & (~(USART_RXEN_bm | USART_TXEN_bm | USART_CLK2X_bm | USART_MPCM_bm | USART_TXB8_bm))) |
; 0007 0039 	USART_RXEN_bm | USART_TXEN_bm;
	LDS  R30,2243
	ANDI R30,LOW(0xE0)
	ORI  R30,LOW(0x18)
	STS  2243,R30
; 0007 003A }
	RET
; .FEND
;
;// Note: RX_BUFFER_SIZE_USARTC0 is #define-d in 'usarts_init.h' with the value 24
;char rx_buffer_usartc0[RX_BUFFER_SIZE_USARTC0];
;
;#if RX_BUFFER_SIZE_USARTC0 <= 256
;volatile unsigned char rx_wr_index_usartc0=0,rx_rd_index_usartc0=0;
;#else
;volatile unsigned int rx_wr_index_usartc0=0,rx_rd_index_usartc0=0;
;#endif
;
;#if RX_BUFFER_SIZE_USARTC0 < 256
;volatile unsigned char rx_counter_usartc0=0;
;#else
;volatile unsigned int rx_counter_usartc0=0;
;#endif
;
;// This flag is set on USARTC0 Receiver buffer overflow
;bit rx_buffer_overflow_usartc0=0;
;
;// USARTC0 Receiver interrupt service routine
;interrupt [USARTC0_RXC_vect] void usartc0_rx_isr(void)
; 0007 0050 {
_usartc0_rx_isr:
; .FSTART _usartc0_rx_isr
	ST   -Y,R26
	ST   -Y,R30
	ST   -Y,R31
	IN   R30,SREG
	ST   -Y,R30
; 0007 0051 unsigned char status;
; 0007 0052 char data;
; 0007 0053 
; 0007 0054 status=USARTC0.STATUS;
	ST   -Y,R17
	ST   -Y,R16
;	status -> R17
;	data -> R16
	LDS  R17,2241
; 0007 0055 data=USARTC0.DATA;
	LDS  R16,2240
; 0007 0056 if ((status & (USART_FERR_bm | USART_PERR_bm | USART_BUFOVF_bm)) == 0)
	MOV  R30,R17
	ANDI R30,LOW(0x1C)
	BRNE _0xE0003
; 0007 0057    {
; 0007 0058    rx_buffer_usartc0[rx_wr_index_usartc0++]=data;
	LDS  R30,_rx_wr_index_usartc0
	SUBI R30,-LOW(1)
	STS  _rx_wr_index_usartc0,R30
	SUBI R30,LOW(1)
	LDI  R31,0
	SUBI R30,LOW(-_rx_buffer_usartc0)
	SBCI R31,HIGH(-_rx_buffer_usartc0)
	ST   Z,R16
; 0007 0059 
; 0007 005A #if RX_BUFFER_SIZE_USARTC0 == 256
; 0007 005B    // special case for receiver buffer size=256
; 0007 005C    if (++rx_counter_usartc0 == 0) rx_buffer_overflow_usartc0=1;
; 0007 005D #else
; 0007 005E    if (rx_wr_index_usartc0 == RX_BUFFER_SIZE_USARTC0) rx_wr_index_usartc0=0;
	LDS  R26,_rx_wr_index_usartc0
	CPI  R26,LOW(0x18)
	BRNE _0xE0004
	LDI  R30,LOW(0)
	STS  _rx_wr_index_usartc0,R30
; 0007 005F    if (++rx_counter_usartc0 == RX_BUFFER_SIZE_USARTC0)
_0xE0004:
	LDS  R26,_rx_counter_usartc0
	SUBI R26,-LOW(1)
	STS  _rx_counter_usartc0,R26
	CPI  R26,LOW(0x18)
	BRNE _0xE0005
; 0007 0060       {
; 0007 0061       rx_counter_usartc0=0;
	LDI  R30,LOW(0)
	STS  _rx_counter_usartc0,R30
; 0007 0062       rx_buffer_overflow_usartc0=1;
	SBI  0x0,0
; 0007 0063       }
; 0007 0064 #endif
; 0007 0065    }
_0xE0005:
; 0007 0066 }
_0xE0003:
	LD   R16,Y+
	LD   R17,Y+
	RJMP _0xE0016
; .FEND
;
;// Receive a character from USARTC0
;// USARTC0 is used as the default input device by the 'getchar' function
;// #define _ALTERNATE_GETCHAR_ is inserted for this purpose
;// in the main program source file before #include <stdio.h>
;#pragma used+
;char getchar(void)
; 0007 006E {
; 0007 006F char data;
; 0007 0070 
; 0007 0071 while (rx_counter_usartc0==0);
;	data -> R17
; 0007 0072 data=rx_buffer_usartc0[rx_rd_index_usartc0++];
; 0007 0073 #if RX_BUFFER_SIZE_USARTC0 != 256
; 0007 0074 if (rx_rd_index_usartc0 == RX_BUFFER_SIZE_USARTC0) rx_rd_index_usartc0=0;
; 0007 0075 #endif
; 0007 0076 #asm("cli")
; 0007 0077 --rx_counter_usartc0;
; 0007 0078 #asm("sei")
; 0007 0079 return data;
; 0007 007A }
;#pragma used-
;
;// Note: TX_BUFFER_SIZE_USARTC0 is #define-d in 'usarts_init.h' with the value 32
;char tx_buffer_usartc0[TX_BUFFER_SIZE_USARTC0];
;
;#if TX_BUFFER_SIZE_USARTC0 <= 256
;volatile unsigned char tx_wr_index_usartc0=0,tx_rd_index_usartc0=0;
;#else
;volatile unsigned int tx_wr_index_usartc0=0,tx_rd_index_usartc0=0;
;#endif
;
;#if TX_BUFFER_SIZE_USARTC0 < 256
;volatile unsigned char tx_counter_usartc0=0;
;#else
;volatile unsigned int tx_counter_usartc0=0;
;#endif
;
;// USARTC0 Transmitter interrupt service routine
;interrupt [USARTC0_TXC_vect] void usartc0_tx_isr(void)
; 0007 008E {
_usartc0_tx_isr:
; .FSTART _usartc0_tx_isr
	ST   -Y,R26
	ST   -Y,R30
	ST   -Y,R31
	IN   R30,SREG
	ST   -Y,R30
; 0007 008F if (tx_counter_usartc0)
	LDS  R30,_tx_counter_usartc0
	CPI  R30,0
	BREQ _0xE000C
; 0007 0090    {
; 0007 0091    --tx_counter_usartc0;
	LDS  R30,_tx_counter_usartc0
	SUBI R30,LOW(1)
	STS  _tx_counter_usartc0,R30
; 0007 0092    USARTC0.DATA=tx_buffer_usartc0[tx_rd_index_usartc0++];
	LDS  R30,_tx_rd_index_usartc0
	SUBI R30,-LOW(1)
	STS  _tx_rd_index_usartc0,R30
	SUBI R30,LOW(1)
	LDI  R31,0
	SUBI R30,LOW(-_tx_buffer_usartc0)
	SBCI R31,HIGH(-_tx_buffer_usartc0)
	LD   R30,Z
	STS  2240,R30
; 0007 0093 #if TX_BUFFER_SIZE_USARTC0 != 256
; 0007 0094    if (tx_rd_index_usartc0 == TX_BUFFER_SIZE_USARTC0) tx_rd_index_usartc0=0;
	LDS  R26,_tx_rd_index_usartc0
	CPI  R26,LOW(0x20)
	BRNE _0xE000D
	LDI  R30,LOW(0)
	STS  _tx_rd_index_usartc0,R30
; 0007 0095 #endif
; 0007 0096    }
_0xE000D:
; 0007 0097 }
_0xE000C:
_0xE0016:
	LD   R30,Y+
	OUT  SREG,R30
	LD   R31,Y+
	LD   R30,Y+
	LD   R26,Y+
	RETI
; .FEND
;
;// Write a character to the USARTC0 Transmitter buffer
;// USARTC0 is used as the default output device by the 'putchar' function
;// #define _ALTERNATE_PUTCHAR_ is inserted for this purpose
;// in the main program source file before #include <stdio.h>
;#pragma used+
;void putchar(char c)
; 0007 009F {
_putchar:
; .FSTART _putchar
; 0007 00A0 while (tx_counter_usartc0 == TX_BUFFER_SIZE_USARTC0);
	ST   -Y,R17
	MOV  R17,R26
;	c -> R17
_0xE000E:
	LDS  R26,_tx_counter_usartc0
	CPI  R26,LOW(0x20)
	BREQ _0xE000E
; 0007 00A1 #asm("cli")
	CLI
; 0007 00A2 if (tx_counter_usartc0 || ((USARTC0.STATUS & USART_DREIF_bm)==0))
	LDS  R30,_tx_counter_usartc0
	CPI  R30,0
	BRNE _0xE0012
	LDS  R30,2241
	ANDI R30,LOW(0x20)
	BRNE _0xE0011
_0xE0012:
; 0007 00A3    {
; 0007 00A4    tx_buffer_usartc0[tx_wr_index_usartc0++]=c;
	LDS  R30,_tx_wr_index_usartc0
	SUBI R30,-LOW(1)
	STS  _tx_wr_index_usartc0,R30
	SUBI R30,LOW(1)
	LDI  R31,0
	SUBI R30,LOW(-_tx_buffer_usartc0)
	SBCI R31,HIGH(-_tx_buffer_usartc0)
	ST   Z,R17
; 0007 00A5 #if TX_BUFFER_SIZE_USARTC0 != 256
; 0007 00A6    if (tx_wr_index_usartc0 == TX_BUFFER_SIZE_USARTC0) tx_wr_index_usartc0=0;
	LDS  R26,_tx_wr_index_usartc0
	CPI  R26,LOW(0x20)
	BRNE _0xE0014
	LDI  R30,LOW(0)
	STS  _tx_wr_index_usartc0,R30
; 0007 00A7 #endif
; 0007 00A8    ++tx_counter_usartc0;
_0xE0014:
	LDS  R30,_tx_counter_usartc0
	SUBI R30,-LOW(1)
	STS  _tx_counter_usartc0,R30
; 0007 00A9    }
; 0007 00AA else
	RJMP _0xE0015
_0xE0011:
; 0007 00AB    USARTC0.DATA=c;
	STS  2240,R17
; 0007 00AC #asm("sei")
_0xE0015:
	SEI
; 0007 00AD }
_0x2080002:
	LD   R17,Y+
	RET
; .FEND
;#pragma used-
;

Jim

I would rather attempt something great and fail, than attempt nothing and succeed - Fortune Cookie

 

"The critical shortage here is not stuff, but time." - Johan Ekdahl

 

"Step N is required before you can do step N+1!" - ka7ehk

 

"If you want a career with a known path - become an undertaker. Dead people don't sue!" - Kartman

"Why is there a "Highway to Hell" and only a "Stairway to Heaven"? A prediction of the expected traffic load?"  - Lee "theusch"

 

Speak sweetly. It makes your words easier to digest when at a later date you have to eat them ;-)  - Source Unknown

Please Read: Code-of-Conduct

Atmel Studio6.2/AS7, DipTrace, Quartus, MPLAB, RSLogix user

Top
clawson
clawson's picture
Level: Moderator
Joined: Mon. Jul 18, 2005
Posts: 99277 View posts
Location: (using avr-gcc in) Finchingfield, Essex, England
Posted by clawson: Wed. Mar 11, 2020 - 02:21 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Eh?

 

;// Receive a character from USARTC0
;// USARTC0 is used as the default input device by the 'getchar' function
;// #define _ALTERNATE_GETCHAR_ is inserted for this purpose
;// in the main program source file before #include <stdio.h>
;#pragma used+
;char getchar(void)
; 0007 006E {
; 0007 006F char data;
; 0007 0070 
; 0007 0071 while (rx_counter_usartc0==0);
;	data -> R17
; 0007 0072 data=rx_buffer_usartc0[rx_rd_index_usartc0++];
; 0007 0073 #if RX_BUFFER_SIZE_USARTC0 != 256
; 0007 0074 if (rx_rd_index_usartc0 == RX_BUFFER_SIZE_USARTC0) rx_rd_index_usartc0=0;
; 0007 0075 #endif
; 0007 0076 #asm("cli")
; 0007 0077 --rx_counter_usartc0;
; 0007 0078 #asm("sei")
; 0007 0079 return data;
; 0007 007A }
;#pragma used-

(but I don't know enough about CV and how it does stdio to know really)

Top
Brian Fairchild
Brian Fairchild's picture
Level: Raving Lunatic
Joined: Thu. Oct 18, 2001
Posts: 4757 View posts
Location: Eastern England.
Posted by Brian Fairchild: Wed. Mar 11, 2020 - 02:25 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Just a random guess but what happens if you put #define _ALTERNATE_GETCHAR_ right next to the alternative getchar() function rather than at the top of main.c?

#1 Hardware Problem? https://www.avrfreaks.net/forum/...

#2 Hardware Problem? Read AVR042.

#3 All grounds are not created equal

#4 Have you proved your chip is running at xxMHz?

#5 "If you think you need floating point to solve the problem then you don't understand the problem. If you really do need floating point then you have a problem you do not understand."

Top
jgmdesign
jgmdesign's picture
Level: Moderator
Joined: Mon. Mar 19, 2007
Posts: 17046 View posts
Location: Long Island New York
Posted by jgmdesign: Wed. Mar 11, 2020 - 02:35 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

clawson wrote:

Eh?

 

;// Receive a character from USARTC0
;// USARTC0 is used as the default input device by the 'getchar' function
;// #define _ALTERNATE_GETCHAR_ is inserted for this purpose
;// in the main program source file before #include <stdio.h>
;#pragma used+
;char getchar(void)
; 0007 006E {
; 0007 006F char data;
; 0007 0070 
; 0007 0071 while (rx_counter_usartc0==0);
;	data -> R17
; 0007 0072 data=rx_buffer_usartc0[rx_rd_index_usartc0++];
; 0007 0073 #if RX_BUFFER_SIZE_USARTC0 != 256
; 0007 0074 if (rx_rd_index_usartc0 == RX_BUFFER_SIZE_USARTC0) rx_rd_index_usartc0=0;
; 0007 0075 #endif
; 0007 0076 #asm("cli")
; 0007 0077 --rx_counter_usartc0;
; 0007 0078 #asm("sei")
; 0007 0079 return data;
; 0007 007A }
;#pragma used-

(but I don't know enough about CV and how it does stdio to know really)

 

Can you elaborate Cliff?  "EH?" can mean many things...

 

Brian Fairchild wrote:

Just a random guess but what happens if you put #define _ALTERNATE_GETCHAR_ right next to the alternative getchar() function rather than at the top of main.c?

THats only used if I have the second USART enabled(which I do not)  And I do not see the Alternative anywhere in the files CV generated.

 

Jim

I would rather attempt something great and fail, than attempt nothing and succeed - Fortune Cookie

 

"The critical shortage here is not stuff, but time." - Johan Ekdahl

 

"Step N is required before you can do step N+1!" - ka7ehk

 

"If you want a career with a known path - become an undertaker. Dead people don't sue!" - Kartman

"Why is there a "Highway to Hell" and only a "Stairway to Heaven"? A prediction of the expected traffic load?"  - Lee "theusch"

 

Speak sweetly. It makes your words easier to digest when at a later date you have to eat them ;-)  - Source Unknown

Please Read: Code-of-Conduct

Atmel Studio6.2/AS7, DipTrace, Quartus, MPLAB, RSLogix user

Top
clawson
clawson's picture
Level: Moderator
Joined: Mon. Jul 18, 2005
Posts: 99277 View posts
Location: (using avr-gcc in) Finchingfield, Essex, England
Posted by clawson: Wed. Mar 11, 2020 - 02:40 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

As getchar()/putchar() are library functions then if you think you have a problem with those what happens if you simply switch to library URTA_get_byte() and UART_put_byte() functions instead.

 

(and my "Eh?" was responding to your suggestion that there was no getchar() and yet I thought I could see something called getchar() in the listing).

Top
jgmdesign
jgmdesign's picture
Level: Moderator
Joined: Mon. Mar 19, 2007
Posts: 17046 View posts
Location: Long Island New York
Posted by jgmdesign: Wed. Mar 11, 2020 - 02:42 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

clawson wrote:
(and my "Eh?" was responding to your suggestion that there was no getchar() and yet I thought I could see something called getchar() in the listing).

 

Ahhh, Ok I know that GetChar() is a library function, but if you look at the code I posted the PUTCHAR() has actual code below teh comments and the GETCHAR() does not appear to.  HEnce my comment.  I am probably wrong, but it would not be the first time...

 

JIm

I would rather attempt something great and fail, than attempt nothing and succeed - Fortune Cookie

 

"The critical shortage here is not stuff, but time." - Johan Ekdahl

 

"Step N is required before you can do step N+1!" - ka7ehk

 

"If you want a career with a known path - become an undertaker. Dead people don't sue!" - Kartman

"Why is there a "Highway to Hell" and only a "Stairway to Heaven"? A prediction of the expected traffic load?"  - Lee "theusch"

 

Speak sweetly. It makes your words easier to digest when at a later date you have to eat them ;-)  - Source Unknown

Please Read: Code-of-Conduct

Atmel Studio6.2/AS7, DipTrace, Quartus, MPLAB, RSLogix user

Top
skeeve
skeeve's picture
Level: Raving Lunatic
Joined: Sun. Oct 29, 2006
Posts: 5203 View posts
Posted by skeeve: Wed. Mar 11, 2020 - 02:59 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

jgmdesign wrote:

When I hit RUN and do nothing for a few seconds then hit PAUSE the window shows that the application is sitting in this spot:

while (rx_counter_usartc0==0);

How does it get there?  I'd thought it was part of getchar(), which is not being reached.

Can you decipher the call stack?

Iluvatar is the better part of Valar.

Top
jgmdesign
jgmdesign's picture
Level: Moderator
Joined: Mon. Mar 19, 2007
Posts: 17046 View posts
Location: Long Island New York
Posted by jgmdesign: Wed. Mar 11, 2020 - 03:19 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

skeeve wrote:
Can you decipher the call stack?

Thats a little over my head.

 

skeeve wrote:

How does it get there?  I'd thought it was part of getchar(), which is not being reached.

 

Something I noticed in Studio....be it a GCC project, or CV is that when you start a debug session, something jumps to the ISR's and other functions.  I have seen this before and I cannot pin it down, but lets not go into that too much....for now.

 

In the meantime I have to step out for a little while.  When I return I will create a USART only project and see if this all works in that application.

 

Jim

I would rather attempt something great and fail, than attempt nothing and succeed - Fortune Cookie

 

"The critical shortage here is not stuff, but time." - Johan Ekdahl

 

"Step N is required before you can do step N+1!" - ka7ehk

 

"If you want a career with a known path - become an undertaker. Dead people don't sue!" - Kartman

"Why is there a "Highway to Hell" and only a "Stairway to Heaven"? A prediction of the expected traffic load?"  - Lee "theusch"

 

Speak sweetly. It makes your words easier to digest when at a later date you have to eat them ;-)  - Source Unknown

Please Read: Code-of-Conduct

Atmel Studio6.2/AS7, DipTrace, Quartus, MPLAB, RSLogix user

Top
clawson
clawson's picture
Level: Moderator
Joined: Mon. Jul 18, 2005
Posts: 99277 View posts
Location: (using avr-gcc in) Finchingfield, Essex, England
Posted by clawson: Wed. Mar 11, 2020 - 03:26 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0


jgmdesign wrote:
Thats a little over my head.
For example...

 

 

The call stack is showing that I'm currently at line 12 of delay_us function that was called from line 20 of main (because the return on the stack will be back to line 21).

Top
ki0bk
ki0bk's picture
Level: Raving Lunatic
Joined: Mon. Sep 8, 2014
Posts: 7044 View posts
Location: Olathe KS
Posted by ki0bk: Wed. Mar 11, 2020 - 03:27 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Jim, can you create a small test program that just echos serial data?

Keep it simple and see if that works.  Just to check your using your tool chain correctly.

 

Jim

 

 

 

 

 

 

 

Top
david.prentice
david.prentice's picture
Level: 10k+ Postman
Joined: Sat. Feb 12, 2005
Posts: 29827 View posts
Location: Wormshill, England
Posted by david.prentice: Wed. Mar 11, 2020 - 05:49 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Please ZIP up your project and attach the ZIP.

 

I do not intend to reconstruct from a maze of pasted code.

It is much easier to just build your project and run it myself.

 

I don't have 32E5 but I do have 32A4U.   It should be straightforward to Simulate the 32E5 or to build and debug on a slightly different hardware chip.

 

Ideally,  you post a minimal project but if "everything is in the ZIP" a reader can unzip and build immediately.

 

David.

Top
theusch
theusch's picture
Level: 10k+ Postman
Joined: Mon. Feb 19, 2001
Posts: 39770 View posts
Location: Wisconsin USA
Posted by theusch: Wed. Mar 11, 2020 - 08:02 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

In earlier post you showed the snapshot of the variable value, and later the generated code for the lds. But you cut off the address in the watch window, so until you do we don't know for sure that it is the same.
Also if you never hit your infinite loop, how do you expect code to be carried out? Again, if you never...

You can put lipstick on a pig, but it is still a pig.

I've never met a pig I didn't like, as long as you have some salt and pepper.

Top
N.Winterbottom
N.Winterbottom's picture
Level: Posting Freak
Joined: Tue. Oct 1, 2002
Posts: 1299 View posts
Location: Redbourn, Herts, UK
Posted by N.Winterbottom: Wed. Mar 11, 2020 - 08:20 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

david.prentice wrote:
Please ZIP up your project and attach the ZIP.

When I read this thread whilst at the office earlier today there definitely was a zipped project attached to one of Jim's posts. I thought to myself "A-Ha - I enjoy a challenge; I'll fire Studio up this evening and find the problem in no time".

 

What gives ?

 

Last Edited: Wed. Mar 11, 2020 - 08:21 PM
Top
jgmdesign
jgmdesign's picture
Level: Moderator
Joined: Mon. Mar 19, 2007
Posts: 17046 View posts
Location: Long Island New York
Posted by jgmdesign: Wed. Mar 11, 2020 - 08:49 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

theusch wrote:
In earlier post you showed the snapshot of the variable value, and later the generated code for the lds. But you cut off the address in the watch window, so until you do we don't know for sure that it is the same.

 

Fair enough.  But I would think that the compiler would throw up something if there were two variables with the same name, but I won't argue.

 

theusch wrote:
Also if you never hit your infinite loop, how do you expect code to be carried out? Again, if you never...

THis is an interesting comment and it hits on what I posted in #30

jgmdesign wrote:
Something I noticed in Studio....be it a GCC project, or CV is that when you start a debug session, something jumps to the ISR's and other functions.  I have seen this before and I cannot pin it down, but lets not go into that too much....for now.

 

So, I took this suggestion:

ki0bk wrote:
Something I noticed in Studio....be it a GCC project, or CV is that when you start a debug session, something jumps to the ISR's and other functions.  I have seen this before and I cannot pin it down, but lets not go into that too much....for now.

 

And did just that.  Created a project using the wizard for JUST THE USARTC0 and nothing else.  I then added the #define and the IF, nothing else.  Hit the START DEBUGGING and let it sit.  Did not touch anything for 10 seconds and then hit PAUSE. 

 

Here is what the MAIN window shows as to where teh program is:

So the program goes straight to that while loop right out of the gate and sits there.  Thats not good.

I restart the process, and now I type a few letters on the keyboard and I get nothing back on the terminal screen.  I pause the debugger and this is what I see:

 

Typing a few letters gets me out of that while loop, and into the main loop, but the if statement is still not resolving.

 

From the LST file:

if (DATARECEIVED()) putchar(getchar());  //This does nothing.  No output

 

Let me know if you need anything else.

 

EDIT:

Project ZIP

Attachment(s): 

Package icon Xmega_Just_Usart.zip

I would rather attempt something great and fail, than attempt nothing and succeed - Fortune Cookie

 

"The critical shortage here is not stuff, but time." - Johan Ekdahl

 

"Step N is required before you can do step N+1!" - ka7ehk

 

"If you want a career with a known path - become an undertaker. Dead people don't sue!" - Kartman

"Why is there a "Highway to Hell" and only a "Stairway to Heaven"? A prediction of the expected traffic load?"  - Lee "theusch"

 

Speak sweetly. It makes your words easier to digest when at a later date you have to eat them ;-)  - Source Unknown

Please Read: Code-of-Conduct

Atmel Studio6.2/AS7, DipTrace, Quartus, MPLAB, RSLogix user

Last Edited: Wed. Mar 11, 2020 - 09:08 PM
Top
awneil
awneil's picture
Level: 10k+ Postman
Joined: Fri. Jul 1, 2005
Posts: 18782 View posts
Location: Basingstoke, Hampshire, UK
Posted by awneil: Wed. Mar 11, 2020 - 09:15 PM (Reply to #36)
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

jgmdesign wrote:
I would think that the compiler would throw up something if there were two variables with the same name

Only if they also had the same scope 

 

EDIT

 

eg, it's possible for a variable in an "inner" scope to "hide" a variable with the same name in an "outer"  scope:

 

void func( void )
{
    int doris;
    
    // code here can access 'doris'
    :
    :
    
    {
        int doris; // "hides" the outer 'doris'
        
        // code here would access the "inner" doris
        
    }
    
    // code here accesses the "outer" doris
}

 

Top Tips:

  1. How to properly post source code - see: https://www.avrfreaks.net/comment... - also how to properly include images/pictures
  2. "Garbage" characters on a serial terminal are (almost?) invariably due to wrong baud rate - see: https://learn.sparkfun.com/tutorials/serial-communication
  3. Wrong baud rate is usually due to not running at the speed you thought; check by blinking a LED to see if you get the speed you expected
  4. Difference between a crystal, and a crystal oscillator: https://www.avrfreaks.net/comment...
  5. When your question is resolved, mark the solution: https://www.avrfreaks.net/comment...
  6. Beginner's "Getting Started" tips: https://www.avrfreaks.net/comment...
Last Edited: Wed. Mar 11, 2020 - 09:19 PM
Top
jgmdesign
jgmdesign's picture
Level: Moderator
Joined: Mon. Mar 19, 2007
Posts: 17046 View posts
Location: Long Island New York
Posted by jgmdesign: Wed. Mar 11, 2020 - 09:20 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

awneil wrote:

jgmdesign wrote:
I would think that the compiler would throw up something if there were two variables with the same name

Only if they also had the same scope 

 

Ok, I'll look that up.

 

What I have determined between my actual app, and a USARTC0 only app is that the both of them do the exact same things.  First is jump to he Getchar() function and sit in the first WHILE loop.  Which is not good.  Second, after they get out of the Getchar() function the IF statement does not appear to resolve....no matter how I write it.

 

JIm

I would rather attempt something great and fail, than attempt nothing and succeed - Fortune Cookie

 

"The critical shortage here is not stuff, but time." - Johan Ekdahl

 

"Step N is required before you can do step N+1!" - ka7ehk

 

"If you want a career with a known path - become an undertaker. Dead people don't sue!" - Kartman

"Why is there a "Highway to Hell" and only a "Stairway to Heaven"? A prediction of the expected traffic load?"  - Lee "theusch"

 

Speak sweetly. It makes your words easier to digest when at a later date you have to eat them ;-)  - Source Unknown

Please Read: Code-of-Conduct

Atmel Studio6.2/AS7, DipTrace, Quartus, MPLAB, RSLogix user

Top
js
js's picture
Level: Moderator
Joined: Wed. Mar 28, 2001
Posts: 29460 View posts
Location: Sydney, Australia (Gum trees, Koalas and Kangaroos, No Edelweis, but plenty of Corona beer)
Posted by js: Thu. Mar 12, 2020 - 02:27 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0


I have recompiled the above test program and uncommented the puts line so that I can see the stuff coming out of the terminal correctly, all is well there.

 

Typing stuff into the terminal goes into the received buffer as you can see (123ABC) so the line #define DATARECEIVED() (rx_counter_usartc0 != 0) or the line if (DATARECEIVED()) putchar(getchar()); is not doing what one may think it should be doing ie send the data in the rx_buffer and decrement the counter. It may just be the case of rewriting the last line but I'm not the best person to do it, in assembler it would be a simple thing........ devil

 

 

 

John Samperi

Ampertronics Pty. Ltd.

www.ampertronics.com.au

* Electronic Design * Custom Products * Contract Assembly

Top
jgmdesign
jgmdesign's picture
Level: Moderator
Joined: Mon. Mar 19, 2007
Posts: 17046 View posts
Location: Long Island New York
Posted by jgmdesign: Thu. Mar 12, 2020 - 02:45 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

John,

if you let the app sit without typing anything and hit PAUSE, you will see that the app is sitting in a WHILE loop in the getchar() function which literally hold the app hostage from doing anything else.  Thats the part I dont understand why it does that.

 

With regards to the whole DEFINE and IF thingie,  if I do this instead:

 

if(rx_counter_usartc0 != 0)
{
    PORTA.OUTSET = PIN5_bm;
}

even after I type some characters into the buffer I still do not get anything to happen thats in teh brackets.

 

Frustrating.

 

JIm

I would rather attempt something great and fail, than attempt nothing and succeed - Fortune Cookie

 

"The critical shortage here is not stuff, but time." - Johan Ekdahl

 

"Step N is required before you can do step N+1!" - ka7ehk

 

"If you want a career with a known path - become an undertaker. Dead people don't sue!" - Kartman

"Why is there a "Highway to Hell" and only a "Stairway to Heaven"? A prediction of the expected traffic load?"  - Lee "theusch"

 

Speak sweetly. It makes your words easier to digest when at a later date you have to eat them ;-)  - Source Unknown

Please Read: Code-of-Conduct

Atmel Studio6.2/AS7, DipTrace, Quartus, MPLAB, RSLogix user

Top
js
js's picture
Level: Moderator
Joined: Wed. Mar 28, 2001
Posts: 29460 View posts
Location: Sydney, Australia (Gum trees, Koalas and Kangaroos, No Edelweis, but plenty of Corona beer)
Posted by js: Thu. Mar 12, 2020 - 03:35 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

I guess that you should not use getchar in your code as the chars are coming in via the interrupts?? (getchar is blocking) So if the counter is not zero then get the data and send it out??

 

I had the putchar(getchar()) bit sort of working somehow by just using the rx_counter_usartc0 != 0 as a variable but then I did some small changes and it is not working again.

 

It requires the help of some heavy duty C and CV gurus.laugh

John Samperi

Ampertronics Pty. Ltd.

www.ampertronics.com.au

* Electronic Design * Custom Products * Contract Assembly

Top
Brian Fairchild
Brian Fairchild's picture
Level: Raving Lunatic
Joined: Thu. Oct 18, 2001
Posts: 4757 View posts
Location: Eastern England.
Posted by Brian Fairchild: Thu. Mar 12, 2020 - 07:42 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

jgmdesign wrote:

First is jump to he Getchar() function and sit in the first WHILE loop.  Which is not good.

 

As John observed, the default getchar(), that the CV Wizard generates, is blocking and will sit there twiddling its thumbs until a character arrives. I deal with this in my code like this...

 

uint8_t getkey(void)
{
    uint8_t key;

    key = NULL;
    gNumeric = FALSE;

    if (rx_counter0) {
        key = getchar();
        if ((key >= '0') && (key <= '9')) {
            gNumeric = TRUE;
        }
    }

    return key;

}

(Apologies for the slightly uneven variable naming convention. 'rx_counter0' is the default CV name and is a global)

 

 

 

[EDIT]

 

Although your macro does do that check, and the generated code looks OK.

#1 Hardware Problem? https://www.avrfreaks.net/forum/...

#2 Hardware Problem? Read AVR042.

#3 All grounds are not created equal

#4 Have you proved your chip is running at xxMHz?

#5 "If you think you need floating point to solve the problem then you don't understand the problem. If you really do need floating point then you have a problem you do not understand."

Last Edited: Thu. Mar 12, 2020 - 08:10 AM
Top
Brian Fairchild
Brian Fairchild's picture
Level: Raving Lunatic
Joined: Thu. Oct 18, 2001
Posts: 4757 View posts
Location: Eastern England.
Posted by Brian Fairchild: Thu. Mar 12, 2020 - 08:38 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

jgmdesign wrote:

if you let the app sit without typing anything and hit PAUSE, you will see that the app is sitting in a WHILE loop in the getchar() function which literally hold the app hostage from doing anything else.  Thats the part I dont understand why it does that.

 

That is very weird. The generated code looks to be correct so the only way to get into getchar() on start up would be if rx_counter_usartc0 was non-zero.

 

                 _0x3:
                 ; 0000 005A       {
                 ; 0000 005B       // Place your code here
                 ; 0000 005C 	   if (DATARECEIVED()) putchar(getchar());  //This does nothing.  No output
000090 91e0 240a 	LDS  R30,_rx_counter_usartc0
000092 30e0      	CPI  R30,0
000093 f019      	BREQ _0x6
000094 d10a      	RCALL _getchar
000095 2fae      	MOV  R26,R30
000096 d14e      	RCALL _putchar
                 ; 0000 005D 
                 ; 0000 005E       }
                 _0x6:
000097 cff8      	RJMP _0x3
                 ; 0000 005F }
                 _0x7:
000098 cfff      	RJMP _0x7

 

Hmmm, how about a bit of defensive programming...

 

    rx_counter_usartc0 = 0;
    n = USARTC0.DATA;
    n = USARTC0.DATA;

    #asm("sei")


    while (1) {
        if (rx_counter_usartc0) {
            n= getchar();
            putchar(n);
        }
    }

The generated code in the while(1) loop is the same but you have separate lines there to set breakpoints on.

#1 Hardware Problem? https://www.avrfreaks.net/forum/...

#2 Hardware Problem? Read AVR042.

#3 All grounds are not created equal

#4 Have you proved your chip is running at xxMHz?

#5 "If you think you need floating point to solve the problem then you don't understand the problem. If you really do need floating point then you have a problem you do not understand."

Top
jgmdesign
jgmdesign's picture
Level: Moderator
Joined: Mon. Mar 19, 2007
Posts: 17046 View posts
Location: Long Island New York
Posted by jgmdesign: Thu. Mar 12, 2020 - 12:34 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Brian Fairchild wrote:
That is very weird. The generated code looks to be correct so the only way to get into getchar() on start up would be if rx_counter_usartc0 was non-zero.

 

I am reluctantly tempted to poke Pavel on this, and prepared for the nasty email response he usually gives.

 

Or I can simply bail on using CV for this and just go GCC and live life in peace. 

 

JIm

I would rather attempt something great and fail, than attempt nothing and succeed - Fortune Cookie

 

"The critical shortage here is not stuff, but time." - Johan Ekdahl

 

"Step N is required before you can do step N+1!" - ka7ehk

 

"If you want a career with a known path - become an undertaker. Dead people don't sue!" - Kartman

"Why is there a "Highway to Hell" and only a "Stairway to Heaven"? A prediction of the expected traffic load?"  - Lee "theusch"

 

Speak sweetly. It makes your words easier to digest when at a later date you have to eat them ;-)  - Source Unknown

Please Read: Code-of-Conduct

Atmel Studio6.2/AS7, DipTrace, Quartus, MPLAB, RSLogix user

Top
ki0bk
ki0bk's picture
Level: Raving Lunatic
Joined: Mon. Sep 8, 2014
Posts: 7044 View posts
Location: Olathe KS
Posted by ki0bk: Thu. Mar 12, 2020 - 01:56 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

jgmdesign wrote:
Thats the part I dont understand why it does that.

getchar() is normally a blocking function, ie. it waits for a character to arrive before returning...

Normally if you don't want to block, you test for the presence of data in the buffer before calling getchar(). 

If using a polled input, then you test the received char flag in the USART reg, or if using an interrupt buffered input, then test for the presence of data in the buffer, either a non-zero count, or pointer positions, before calling getchar(). 

 

Jim

edit: spelling

 

 

 

 

Last Edited: Thu. Mar 12, 2020 - 01:58 PM
Top
clawson
clawson's picture
Level: Moderator
Joined: Mon. Jul 18, 2005
Posts: 99277 View posts
Location: (using avr-gcc in) Finchingfield, Essex, England
Posted by clawson: Thu. Mar 12, 2020 - 01:59 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

ki0bk wrote:
Normally if you don't want to block, you test for the presence of data in the buffer before calling getchar(). 
Isn't that exactly what (other) Jim's DATARECEIVED() macro is all about? It's checking the global RXC interrupt counter to see if there's anything in the ring buffer.

Top
david.prentice
david.prentice's picture
Level: 10k+ Postman
Joined: Sat. Feb 12, 2005
Posts: 29827 View posts
Location: Wormshill, England
Posted by david.prentice: Thu. Mar 12, 2020 - 02:13 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Yes,  Jim's macro is fine.  rx_counter_usartc0 is a global variable.   accessible to the user.

And testing before calling getchar() is a wise and safe approach.     DATARECEIVED() might not be the best choice of name but it is perfectly adequate.

 

I would worry more about the "quality" of any Serial Terminal software.    Especially from AS7.0

 

David.

Top
Brian Fairchild
Brian Fairchild's picture
Level: Raving Lunatic
Joined: Thu. Oct 18, 2001
Posts: 4757 View posts
Location: Eastern England.
Posted by Brian Fairchild: Thu. Mar 12, 2020 - 02:32 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

jgmdesign wrote:

Or I can simply bail on using CV for this and just go GCC and live life in peace. 

 

I don't think it's a compiler problem; I've poked at the .lst file and everything looks right.

#1 Hardware Problem? https://www.avrfreaks.net/forum/...

#2 Hardware Problem? Read AVR042.

#3 All grounds are not created equal

#4 Have you proved your chip is running at xxMHz?

#5 "If you think you need floating point to solve the problem then you don't understand the problem. If you really do need floating point then you have a problem you do not understand."

Top
clawson
clawson's picture
Level: Moderator
Joined: Mon. Jul 18, 2005
Posts: 99277 View posts
Location: (using avr-gcc in) Finchingfield, Essex, England
Posted by clawson: Thu. Mar 12, 2020 - 02:45 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Brian Fairchild wrote:
I don't think it's a compiler problem; I've poked at the .lst file and everything looks right.
Totally agree. This looks pretty unequivocal:

000090 91e0 240a 	LDS  R30,_rx_counter_usartc0
000092 30e0      	CPI  R30,0
000093 f019      	BREQ _0x6

Part of the mystery here seems to be Jim seeing rc_counter_usartc0 = 0x04 in the debugger but it apparently taking this branch anyway.

 

I have a rather strong distrust of debuggers myself based on a number of unpleasant experiences over the years so if I was backing anything here it would be that the debugger is lying about the 0x04 !

 

If CV produces a .map file I'd find the location of that global (I suppose one could extract it from 91E0 240A in fact?) and find out where the variable is really located then put a debugger raw "Memory Window" on that and see what's really there. (in case it's own symbolic mapping of the symbol to memory location is on the fritz).

Top
david.prentice
david.prentice's picture
Level: 10k+ Postman
Joined: Sat. Feb 12, 2005
Posts: 29827 View posts
Location: Wormshill, England
Posted by david.prentice: Thu. Mar 12, 2020 - 02:51 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

CV is very pleasant to debug.   You can find most variables.   Trace execution,   ...

 

CV provides .LST and .MAP files as well as the .ASM file.

 

I would like to know what hardware is being used i.e. dongle,  RS232 cable, ...

and what Serial Terminal software is being used.

 

David.

Top
Brian Fairchild
Brian Fairchild's picture
Level: Raving Lunatic
Joined: Thu. Oct 18, 2001
Posts: 4757 View posts
Location: Eastern England.
Posted by Brian Fairchild: Thu. Mar 12, 2020 - 02:52 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

clawson wrote:

If CV produces a .map file I'd find the location of that global...

 

It does...

 

Variable                                                                          Address   Size
------------------------------------------------------------------------------------------------
rx_buffer_usartc0                                                                 0x2400       8
rx_wr_index_usartc0                                                               0x2408       1
rx_rd_index_usartc0                                                               0x2409       1
rx_counter_usartc0                                                                0x240A       1
tx_buffer_usartc0                                                                 0x240B       8
tx_wr_index_usartc0                                                               0x2413       1
tx_rd_index_usartc0                                                               0x2414       1
tx_counter_usartc0                                                                0x2415       1

#1 Hardware Problem? https://www.avrfreaks.net/forum/...

#2 Hardware Problem? Read AVR042.

#3 All grounds are not created equal

#4 Have you proved your chip is running at xxMHz?

#5 "If you think you need floating point to solve the problem then you don't understand the problem. If you really do need floating point then you have a problem you do not understand."

Top

Pages

View All