ASF - spi_write_packet error on lenght

Log in or register to post comments
Go To Last Post
12 posts / 0 new
Author
Message
metRo_
metRo_'s picture
Level: Hangaround
Joined: Thu. Nov 19, 2009
Posts: 117 View posts
#1
Posted by metRo_: Sun. Mar 30, 2014 - 01:31 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Hi,
I'm using SPI from ASF and there is a problem on the function spi_write_packet. Per example:

spi_write_packet(&SPIC, data, 3);

it will send only 2 bytes and not 3.

spi_write_packet(&SPIC, data, 1);

it will send 1 byte but

spi_write_packet(&SPIC, data, 2);

also send only one byte :s

I checked it on the logic analyser after spend some time wondering why the radio transceiver was discard the packets because incorrect payload, the problem comes from this function that send one byte less that the one I pass as argument.

Do you have any idea why that happens?

This is how I'm using it:

void spi_write_multiple_teste(uint8_t * data, uint8_t len){

	struct spi_device spi_device_conf = {
		.id = IOPORT_CREATE_PIN(PORTR, 0)
	};

	spi_select_device(&SPIC, &spi_device_conf);
	spi_write_packet(&SPIC, data, 3);
	spi_deselect_device(&SPIC, &spi_device_conf);
}

I hardcoded the len value for debug purpose. You can see the attached image of this case.

Thank you

Attachment(s): 

Image icon spi_error.png

Tags:

Tools, Atmel Software Framework (ASF) and Atmel Start (ASFv4) (AVR-related)
Top
Gold Markclawson
clawson's picture
Level: Moderator
Joined: Mon. Jul 18, 2005
Posts: 104798 View posts
Location: (using avr-gcc in) Finchingfield, Essex, England
Posted by clawson: Sun. Mar 30, 2014 - 09:51 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

AVR, Xmega, ARM, UC3?

Top
metRo_
metRo_'s picture
Level: Hangaround
Joined: Thu. Nov 19, 2009
Posts: 117 View posts
Posted by metRo_: Sun. Mar 30, 2014 - 10:31 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

clawson wrote:
AVR, Xmega, ARM, UC3?
Xmega 32E5. I was confused if I should post it here or in xmega forum :s

Top
John_A_Brown
John_A_Brown's picture
Level: Raving Lunatic
Joined: Sat. Sep 20, 2003
Posts: 6214 View posts
Location: Underneath the Cotswolds escarpment, England.
Posted by John_A_Brown: Sun. Mar 30, 2014 - 12:05 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

If I remember correctly from when I was using the ASF drivers for a TFT display via SPI, one has to wait for the last byte to have gone before deselecting. This is because the functions that send a single byte checks beforehand to see if the buffer is empty.
So I would try waiting for tx empty before de-asserting CS.
http://asf.atmel.com/docs/3.8.1/sam4s/html/spi_8h.html#a6ffd41921b3092e4a73f659f8ee37cdf

Having said this, your timing diagram does not readily support my theory, but it's the best answer so far!

Four legs good, two legs bad, three legs stable.

Top
metRo_
metRo_'s picture
Level: Hangaround
Joined: Thu. Nov 19, 2009
Posts: 117 View posts
Posted by metRo_: Sun. Mar 30, 2014 - 01:09 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

John_A_Brown wrote:
If I remember correctly from when I was using the ASF drivers for a TFT display via SPI, one has to wait for the last byte to have gone before deselecting. This is because the functions that send a single byte checks beforehand to see if the buffer is empty.
So I would try waiting for tx empty before de-asserting CS.
http://asf.atmel.com/docs/3.8.1/sam4s/html/spi_8h.html#a6ffd41921b3092e4a73f659f8ee37cdf

Having said this, your timing diagram does not readily support my theory, but it's the best answer so far!

I forgot to say that it isn't send the first byte of the buffer.

This is how I create the buffer to send. On the debug I confirm that the buffer was ok before call spi_write_multiple_teste.

void spi_write_cmd(uint8_t cmd, uint8_t * value, uint8_t len){
	
	uint8_t buffer[len+1];
	buffer[0] = (cmd);
	uint8_t i = 0;
	for(i=0;i
Top
John_A_Brown
John_A_Brown's picture
Level: Raving Lunatic
Joined: Sat. Sep 20, 2003
Posts: 6214 View posts
Location: Underneath the Cotswolds escarpment, England.
Posted by John_A_Brown: Sun. Mar 30, 2014 - 06:39 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

I'm sorry, but I do not understand what you are trying to say. Did you try what I suggested?

Four legs good, two legs bad, three legs stable.

Top
rev
rev's picture
Level: Resident
Joined: Mon. Jun 25, 2001
Posts: 655 View posts
Location: Melbourne Australia
Posted by rev: Mon. Mar 31, 2014 - 10:57 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

sounds like a bug ? I am talking to a si4463 and use only the single byte spi send and repeat it as often as it is required which is why i havent seen the issue you describe. What rf chip are you using ?

Top
rev
rev's picture
Level: Resident
Joined: Mon. Jun 25, 2001
Posts: 655 View posts
Location: Melbourne Australia
Posted by rev: Mon. Mar 31, 2014 - 11:38 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Forgot to ask. What version of ASF are you using ?

Top
metRo_
metRo_'s picture
Level: Hangaround
Joined: Thu. Nov 19, 2009
Posts: 117 View posts
Posted by metRo_: Mon. Mar 31, 2014 - 12:33 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

John_A_Brown wrote:
I'm sorry, but I do not understand what you are trying to say. Did you try what I suggested?

You said me to wait a little more to see if there is another byte sent but my problem is the first byte from the buffer that isn't send.

For example:
uint8_t buffer[5] = {1,2,3,4,5};

it send the values 2,3,4,5 if len = 5 but if len=6 then it sends 2,3,4,5,X.

PS: sorry my english

Top
John_A_Brown
John_A_Brown's picture
Level: Raving Lunatic
Joined: Sat. Sep 20, 2003
Posts: 6214 View posts
Location: Underneath the Cotswolds escarpment, England.
Posted by John_A_Brown: Mon. Mar 31, 2014 - 10:41 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Well I think you'll have to debug it yourself. Find the ASF library function and check out what's actually happening.

Four legs good, two legs bad, three legs stable.

Top
Bronze Markjs
js's picture
Level: Moderator
Joined: Wed. Mar 28, 2001
Posts: 31213 View posts
Location: Sydney, Australia (Gum trees, Koalas and Kangaroos, No Edelweis, but plenty of Corona beer)
Posted by js: Tue. Apr 1, 2014 - 01:29 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Isn't it great that we have an ASF to deal with the extreme complicated stuff like the SPI....don't know how we all managed 30 years ago without it.. :?

John Samperi

Ampertronics Pty. Ltd.

https://www.ampertronics.com.au

* Electronic Design * Custom Products * Contract Assembly

Top
John_A_Brown
John_A_Brown's picture
Level: Raving Lunatic
Joined: Sat. Sep 20, 2003
Posts: 6214 View posts
Location: Underneath the Cotswolds escarpment, England.
Posted by John_A_Brown: Tue. Apr 1, 2014 - 07:05 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

js wrote:
Isn't it great that we have an ASF to deal with the extreme complicated stuff like the SPI....don't know how we all managed 30 years ago without it.. :?

I totally agree. I never used ASF before I started using the SAM4, which is slightly more complex than XMegas.

Four legs good, two legs bad, three legs stable.

Top