Is it OK to use macros like this?

Log in or register to post comments
Go To Last Post
10 posts / 0 new
Author
Message
immo
immo's picture
Level: Rookie
Joined: Tue. Nov 4, 2008
Posts: 38 View posts
#1
Posted by immo: Thu. Nov 13, 2008 - 02:23 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Is it OK to use macros like this? Does it violate some golden rules of programming?

#define inputPin ((PINA >> 0) & 0x01)
#define HIGH 1
#define LOW 0

// *SETUP PORTA*
// Pin40, PA0: Input, InputPin
// Pin39, PA1: Output, OutPutPin
// Pin38, PA2: OutPut for LED
// Pins:   76543210
// Values: 00000110  0x06
DDRA = 0x06

while(inputPin == LOW)
{
    //Blink LED
    // LED ON
    PORTA |= (1 << PA2);
    _delay_ms(200);
    //LED OFF
    PORTA &= ~(1 << PA2);
}

Tags:

Tools, Compilers and General Programming
Top
EW
EW's picture
Level: Raving Lunatic
Joined: Thu. Mar 1, 2001
Posts: 4914 View posts
Location: Rocky Mountains
Posted by EW: Thu. Nov 13, 2008 - 02:54 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

It doesn't violate any rule that I'm aware of.

Eric Weddington
www.linkedin.com/in/ericweddington/

Top
Bronze Markjs
js's picture
Level: Moderator
Joined: Wed. Mar 28, 2001
Posts: 29754 View posts
Location: Sydney, Australia (Gum trees, Koalas and Kangaroos, No Edelweis, but plenty of Corona beer)
Posted by js: Thu. Nov 13, 2008 - 04:07 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Quote:
Does it violate some golden rules of programming?
While your macro may not, your code does. Let me guess, the led does not flash as expected? Always on? (it's a common problem with led flashing programs) :wink:

John Samperi

Ampertronics Pty. Ltd.

www.ampertronics.com.au

* Electronic Design * Custom Products * Contract Assembly

Top
Koshchi
Koshchi's picture
Level: 10k+ Postman
Joined: Wed. Nov 17, 2004
Posts: 15658 View posts
Location: Vancouver, BC
Posted by Koshchi: Thu. Nov 13, 2008 - 04:31 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0
(PINA >> 0)

I'm not sure why you would do this. PINA shifted 0 places is just PINA.

Regards,
Steve A.

The Board helps those that help themselves.

Top
immo
immo's picture
Level: Rookie
Joined: Tue. Nov 4, 2008
Posts: 38 View posts
Posted by immo: Thu. Nov 13, 2008 - 05:42 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Quote:
I'm not sure why you would do this. PINA shifted 0 places is just PINA.
I see your point and agree. I just did this to keep the format the same as in the rest or my code for the other pins on that port, ie in the places where I do (PINA >> 1) or (PINA >> 2).

Quote:
Let me guess, the led does not flash as expected? Always on? (it's a common problem with led flashing programs)
I have not tested this exact program with hardware yet. However I cut-paste from another of my programs that does blink the LED and then stay off. However, in that program I was not using a macro. Maybe that is the issue? Where exactly are you thinking there is an issue?

Top
Jepael
Jepael's picture
Level: Raving Lunatic
Joined: Mon. May 24, 2004
Posts: 6270 View posts
Location: Tampere, Finland
Posted by Jepael: Thu. Nov 13, 2008 - 07:41 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

You set the led on, wait a long time, turn the led off, and immediately turn it on again. You won't have time to see it is off.

Another thing is that it is more optimal to say

PINA & (1<<5)

than 

(PINA>>5) & 0x01

because of compiler optimizations.

Top
Bronze Markjs
js's picture
Level: Moderator
Joined: Wed. Mar 28, 2001
Posts: 29754 View posts
Location: Sydney, Australia (Gum trees, Koalas and Kangaroos, No Edelweis, but plenty of Corona beer)
Posted by js: Thu. Nov 13, 2008 - 08:28 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0
while(inputPin == LOW) 
{ 
    //Blink LED 
    // LED ON 
    PORTA |= (1 << PA2); 
    _delay_ms(200); 
    //LED OFF 
    PORTA &= ~(1 << PA2);
    _delay_ms(200);  
}

Notice the difference? :)

John Samperi

Ampertronics Pty. Ltd.

www.ampertronics.com.au

* Electronic Design * Custom Products * Contract Assembly

Top
stu_san
stu_san's picture
Level: Raving Lunatic
Joined: Fri. Dec 30, 2005
Posts: 2321 View posts
Location: Fort Collins, CO USA
Posted by stu_san: Thu. Nov 13, 2008 - 03:53 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

You might also want to read [TUT] [C] [GCC] How to define a pin as a variable

Stu

Engineering seems to boil down to: Cheap. Fast. Good. Choose two. Sometimes choose only one.

Newbie? Be sure to read the thread Newbie? Start here!

Top
immo
immo's picture
Level: Rookie
Joined: Tue. Nov 4, 2008
Posts: 38 View posts
Posted by immo: Thu. Nov 13, 2008 - 05:33 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Quote:
Notice the difference?
I see what you are saying. The LED part of this code was put in just as an example, from another project where this code was only called once. My real questions was about the macro. Thanks for your suggestion.

Top
immo
immo's picture
Level: Rookie
Joined: Tue. Nov 4, 2008
Posts: 38 View posts
Posted by immo: Thu. Nov 13, 2008 - 05:34 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Quote:

Another thing is that it is more optimal to say

Code:

PINA & (1<<5)


OK, this is good to know. Thanks.

Top