I don't want unreferenced functions!

Log in or register to post comments
Go To Last Post
16 posts / 0 new
Author
Message
reSpawn
reSpawn's picture
Level: Wannabe
Joined: Sat. Jun 9, 2007
Posts: 62 View posts
Location: Romania, Oradea
#1
Posted by reSpawn: Sun. Dec 9, 2007 - 10:15 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Hello.
As you all know, the flash space is very limited.. so I don't want avr-gcc to compile unreferenced functions.
How can I do that? Currently I'm using the -Os flag for size optimizations...
Here's a test:

...
void wow()
{
	printf("sunt wow!\n");
	uartTxSync();

}

void wow2()
{
	printf("sunt wow2!\n");
	uartTxSync();
}
...

with those functions:

AVR Memory Usage
----------------
Device: atmega8
Program:    6034 bytes (73.7% Full)
(.text + .data + .bootloader)
Data:        483 bytes (47.2% Full)
(.data + .bss + .noinit)

and without them

AVR Memory Usage
----------------
Device: atmega8
Program:    5892 bytes (71.9% Full)
(.text + .data + .bootloader)
Data:        463 bytes (45.2% Full)
(.data + .bss + .noinit)

Thank you in advance,
Nicu.

Nicu reSpawn.

Tags:

Tools, Compilers and General Programming, ATmega8
Top
kmr
kmr's picture
Level: Raving Lunatic
Joined: Thu. Apr 1, 2004
Posts: 3720 View posts
Location: New Mexico
Posted by kmr: Sun. Dec 9, 2007 - 10:19 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Did you try moving those sometimes referenced functions into separate files? The linker will likely have an easier time excluding an unreferenced function if it is a separate object file.

Kevin Rosenberg
http://b9.com
http://kevin.hypershots.com

Top
reSpawn
reSpawn's picture
Level: Wannabe
Joined: Sat. Jun 9, 2007
Posts: 62 View posts
Location: Romania, Oradea
Posted by reSpawn: Sun. Dec 9, 2007 - 10:23 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Hi Kevin,
I haven't. If I would do that I would waste time making a special file for every function ... I guess there is a special parameter but I couldn't find it.
later edit:
I've found this post http://gcc.gnu.org/ml/gcc/1999-1... about this.
I've tried those parameters on gcc and ld and I have the same result.

Nicu reSpawn.

Top
curtvm
curtvm's picture
Level: Raving Lunatic
Joined: Wed. Sep 21, 2005
Posts: 3181 View posts
Posted by curtvm: Sun. Dec 9, 2007 - 11:12 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

check this-
https://www.avrfreaks.net/index.p...

don't know if it helps you or not, though

Top
kmr
kmr's picture
Level: Raving Lunatic
Joined: Thu. Apr 1, 2004
Posts: 3720 View posts
Location: New Mexico
Posted by kmr: Mon. Dec 10, 2007 - 12:15 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

reSpawn wrote:
If I would do that I would waste time making a special file for every function ... I guess there is a special parameter but I couldn't find it.
I'm using IAR now so I've not kept up with learning to get the most out of GCC. But, in general, if you are make a library of functions for reuse that may or may not be linked into your project, the time to make a set of small files you maintain may be worth it. The link that curtvm supplied to you has some excellent points about library creation as well as probably the compiler and linker options that you are searching for.

BTW, IAR automatically removes unused functions without a command-line option. Instead, IAR has a C extension to indicate that you want a function or variable included in the output, even if that function/variable is unreferenced.

Kevin Rosenberg
http://b9.com
http://kevin.hypershots.com

Top
cpluscon
cpluscon's picture
Level: Raving Lunatic
Joined: Mon. Jul 10, 2006
Posts: 2724 View posts
Location: Minneapolis
Posted by cpluscon: Mon. Dec 10, 2007 - 03:07 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Use static:

Quote:
static void wow()
Since no other code references wow in the same file, the compiler can ignore it. Otherwise, the compiler must include it in case wow is used in another file.

Perhaps the linker has an option to identify dead code, but apparently that behavior is not the default.

C: i = "told you so";

Top
dkinzer
dkinzer's picture
Level: Posting Freak
Joined: Fri. Mar 12, 2004
Posts: 1299 View posts
Location: Portland, OR, USA
Posted by dkinzer: Mon. Dec 10, 2007 - 03:22 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

reSpawn wrote:
I don't want avr-gcc to compile unreferenced functions.
The two functions that you've written have global scope so the compiler cannot possibly know whether or not they're referenced from other modules. Consequently, the compiler must include them in the .o file. Then, when the linker processes the .o files it includes the entire content even if there are no references to some of the functions within it.

It is possible that the linker has an option to exclude unreferenced code. You'll have to review the linker options to find out.

If you add the static attribute to the functions, I suspect that the compiler will omit them since it can then determine that there are no references. In fact, if you do that the compiler will probably issue a warning that the functions are unused.

If the functions must be public, the only option, as I see it, is to break down your application more finely and place most of the modules in a .a archive. Then the linker can pull from the archive only the modules that it needs for a particular build of your application.

Don Kinzer
ZBasic Microcontrollers
http://www.zbasic.net

Top
dl8dtl
dl8dtl's picture
Level: Raving Lunatic
Joined: Fri. Dec 20, 2002
Posts: 7506 View posts
Location: Dresden, Germany
Posted by dl8dtl: Mon. Dec 10, 2007 - 09:08 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

> I haven't. If I would do that I would waste time making a special
> file for every function ...

Curious, where's the time wasted for that?

Yes, there are linker options to remove unused functions. However, I've still
got the feeling that in 99 % of the scenarios, the existence of functions that
aren't needed at all is rather a strong indication of a chaotic design than
a feature that's worth having (at least outside of library code, and for
libraries, the one file per function approach has proven to work for a couple
of decades now).

These linker options have some merit in connection with C++ though, but that's
an entirely differen thing.

Jörg Wunsch

Please don't send me PMs, use email if you want to approach me personally.

Top
Gold Markclawson
clawson's picture
Level: Moderator
Joined: Mon. Jul 18, 2005
Posts: 101096 View posts
Location: (using avr-gcc in) Finchingfield, Essex, England
Posted by clawson: Mon. Dec 10, 2007 - 11:51 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Needless to say, as ever, the USER MANUAL has a useful article about this:

http://www.nongnu.org/avr-libc/u...

Top
cpluscon
cpluscon's picture
Level: Raving Lunatic
Joined: Mon. Jul 10, 2006
Posts: 2724 View posts
Location: Minneapolis
Posted by cpluscon: Mon. Dec 10, 2007 - 04:19 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

dl8dtl wrote:
the existence of functions that
aren't needed at all is rather a strong indication of a chaotic design
We purchased and incorporated a large body of source code to support a particular wireless protocol. Since we only needed a small portion of the protocol, much of that source code was not needed but contributed to a flash shortage we had to deal with.

I agree with your observation, but based on experience, doubt the 99% estimate. Enhancing the linker's ability to remove dead code should be high on the todo list, especially with regard to memory-limited microcontrollers.

C: i = "told you so";

Top
dl8dtl
dl8dtl's picture
Level: Raving Lunatic
Joined: Fri. Dec 20, 2002
Posts: 7506 View posts
Location: Dresden, Germany
Posted by dl8dtl: Mon. Dec 10, 2007 - 04:28 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

No need for a todo list, the feature is there. You just have to make use
of it.

I don't think a misconfigured protocol stack can be fixed by that though.
Usually, dispatching the protocol event is done based on message types at
run-time, so at link-time, everything is still referenced anyway.

Jörg Wunsch

Please don't send me PMs, use email if you want to approach me personally.

Top
cpluscon
cpluscon's picture
Level: Raving Lunatic
Joined: Mon. Jul 10, 2006
Posts: 2724 View posts
Location: Minneapolis
Posted by cpluscon: Mon. Dec 10, 2007 - 04:54 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Quote:
No need for a todo list, the feature is there.
Then hopefully someone will provide usage details for reSpawn and anyone else that is interested. I always assume that complex features can be improved to some extent, but as usual may be mistaken in this case.
Quote:
dispatching the protocol event is done based on messages
There were messages and indeed layers that simply would never see the light of day in our app. Sure, we could identify the biggies and #if them out, but this is a hassle when you consider that the source code will be continually rev'ed by the vendor.

C: i = "told you so";

Top
reSpawn
reSpawn's picture
Level: Wannabe
Joined: Sat. Jun 9, 2007
Posts: 62 View posts
Location: Romania, Oradea
Posted by reSpawn: Mon. Dec 10, 2007 - 05:33 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0
CFLAGS += -ffunction-sections
LDFLAGS += -Wl,-gc-sections

Seems to work on some functions(my hex is 10% lighter :) ) but on wow() and wow2() it does not, only if I declare them static.

Nicu reSpawn.

Top
EW
EW's picture
Level: Raving Lunatic
Joined: Thu. Mar 1, 2001
Posts: 4914 View posts
Location: Rocky Mountains
Posted by EW: Tue. Dec 11, 2007 - 04:12 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Code:
CFLAGS += -ffunction-sections
LDFLAGS += -Wl,-gc-sections

These are the switches needed to remove (Garbage Collect) unused functions, by putting them in their own sections and telling the linker to garbage collect them if they are not referenced.

Eric Weddington
www.linkedin.com/in/ericweddington/

Top
urriz77
urriz77's picture
Level: Rookie
Joined: Sun. Sep 7, 2003
Posts: 29 View posts
Posted by urriz77: Wed. Dec 12, 2007 - 02:27 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Quote:

CFLAGS += -ffunction-sections
LDFLAGS += -Wl,-gc-sections

yes, it works, but also removes used functions.
tryed to add 'used' attribute, but it don't help.

Top
stu_san
stu_san's picture
Level: Raving Lunatic
Joined: Fri. Dec 30, 2005
Posts: 2321 View posts
Location: Fort Collins, CO USA
Posted by stu_san: Wed. Dec 12, 2007 - 04:41 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

urriz77 wrote:
Quote:

CFLAGS += -ffunction-sections
LDFLAGS += -Wl,-gc-sections
yes, it works, but also removes used functions. tried to add 'used' attribute, but it don't help.
Huh? What do you mean "removes used functions"?

If you are using the optimization level -Os (and you should be using it!), the optimizer will "inline" some functions if it judges that they will be faster and smaller for that. Static functions are the usual candidates for this. The functions will seem to be removed, but are actually still there.

Is this what you mean?

Stu

Engineering seems to boil down to: Cheap. Fast. Good. Choose two. Sometimes choose only one.

Newbie? Be sure to read the thread Newbie? Start here!

Top