[ASM] Opcode collision in AVR instruction set ?

Log in or register to post comments
Go To Last Post
13 posts / 0 new
Author
Message
Milo-D
Milo-D's picture
Level: Wannabe
Joined: Fri. Nov 1, 2019
Posts: 67 View posts
#1
Posted by Milo-D: Fri. Mar 12, 2021 - 12:05 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Hello,

 

LDS (16-bit version) is defined as 1010 0kkk dddd kkkk (big endian)

 

and

 

LDD (using Z-pointer with displacement) is defined as 10q0 qq0d dddd 0qqq (big endian)

 

Now given following opcode

 

0xa400 (big endian) in hexadecimal and 1010 0100 0000 0000 (big endian) in binary,

 

this might be

lds r16, 0x20

because of

1010 0100 0000 0000 (0xa400)
1010 0kkk dddd kkkk (LDS 16-bit)

and ADDR[7:0] := (¬INST[8], INST[8], INST[10], INST[9],
                   INST[3], INST[2], INST[1],  INST[0])

==> ADDR[7:0] = 2^5 (INST[10] = 1) = 32 = 0x20

and r16 because of dddd = 0, with 16 <= d <= 31 ==> rd = 16

 

but the same opcode might be

 

ldd r0, Z+40

because of

1010 0100 0000 0000 (0xa400)
10q0 qq0d dddd 0qqq (LDD, Z + disp.)

so q = 2^3 + 2^5 = 40 (decimal) ==> Z+40

and d = 0 ==> rd = r0

 

Now "ldd r0, Z+40" and "lds r16, 0x20" are obviously not the same instruction.

 

The only way in which this collision can not cause problems would be that both instructions
are never supported by a microcontroller at the same time.

 

Does anyone know more ?

 

Tags:

AVR Microcontrollers, megaAVR and tinyAVR
Top
Bronze Markjs
js's picture
Level: Moderator
Joined: Wed. Mar 28, 2001
Posts: 30656 View posts
Location: Sydney, Australia (Gum trees, Koalas and Kangaroos, No Edelweis, but plenty of Corona beer)
Posted by js: Fri. Mar 12, 2021 - 12:10 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

I'm confused but maybe I never came across this conundrum in the past 21+ years of using the assembler.

John Samperi

Ampertronics Pty. Ltd.

https://www.ampertronics.com.au

* Electronic Design * Custom Products * Contract Assembly

Top
Milo-D
Milo-D's picture
Level: Wannabe
Joined: Fri. Nov 1, 2019
Posts: 67 View posts
Posted by Milo-D: Fri. Mar 12, 2021 - 12:31 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Okay, I have tried to find an opcode for LDS without colliding with LDD.

 

The result is that I can not find an opcode for LDS-only. Whenever I try to manipulate some bits in order to find one, it collides with either LDD (Z pointer), LDD (Y pointer), STD (Y pointer).

 

So my assumption is that there exists either LDS or Load/Store with displacement instructions on a single type of microcontroller, but never both.

Top
MattRW
MattRW's picture
Level: Resident
Joined: Thu. Feb 14, 2019
Posts: 745 View posts
Location: Los Angeles area
Posted by MattRW: Fri. Mar 12, 2021 - 12:53 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0


Your decoder needs to track which CPU version you have: AVRe vs AVRxm vs AVRxt vs AVRrc.

Look at the instruction manual.

 

EDIT: look at the last line below

Last Edited: Fri. Mar 12, 2021 - 01:00 AM
Top
Milo-D
Milo-D's picture
Level: Wannabe
Joined: Fri. Nov 1, 2019
Posts: 67 View posts
Posted by Milo-D: Fri. Mar 12, 2021 - 12:56 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Finally, the AVRtiny core deletes the 2-word LDS LDS and STS STS instructions for direct RAM addressing, and instead uses the opcode space previously assigned to the load/store with displacement instructions for new 1-word LDS LDS and STS STS instructions which can access the first 128 locations of general-purpose RAM, addresses 0x40 to 0xBF. https://en.wikipedia.org/wiki/At...

So they removed 32-bit STS/LDS from AVRtiny core and replaced the displacement instructions by 16-bit LDS/STS.

Top
avrcandies
avrcandies's picture
Level: Raving Lunatic
Joined: Wed. Jun 30, 2004
Posts: 7377 View posts
Location: Cincinnati Oh
Posted by avrcandies: Fri. Mar 12, 2021 - 12:57 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0


Good old Studio 4 mentions this:

 

(note this is prob from 10 years ago):

Devices using the AVR8L CPU: ATtiny10, ATtiny20, ATtiny40.

The AVR8L CPU core is a low-cost version of the AVR, and lacks certain features found in regular AVR, most notably:

  • Register file is 16 registers instead of 32 (R16-R31). The assembler will produce an error message if registers R0-R15 are used.

  • Instruction set is reduced, see table below. Notice that the LDS/STS instructions are different from regular AVRs, it is a 1-word instruction with an addressing range of 128 bytes. Also notice that the LPM instruction is eliminated; the Flash memory is mapped into data memory and can be read by means of using the LD instruction.

When in the dark remember-the future looks brighter than ever.   I look forward to being able to predict the future!

Top
Milo-D
Milo-D's picture
Level: Wannabe
Joined: Fri. Nov 1, 2019
Posts: 67 View posts
Posted by Milo-D: Fri. Mar 12, 2021 - 01:01 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

avrcandies wrote:

Good old Studio 4 mentions this:

 

(note this is prob from 10 years ago):

Devices using the AVR8L CPU: ATtiny10, ATtiny20, ATtiny40.

The AVR8L CPU core is a low-cost version of the AVR, and lacks certain features found in regular AVR, most notably:

  • Register file is 16 registers instead of 32 (R16-R31). The assembler will produce an error message if registers R0-R15 are used.

  • Instruction set is reduced, see table below. Notice that the LDS/STS instructions are different from regular AVRs, it is a 1-word instruction with an addressing range of 128 bytes. Also notice that the LPM instruction is eliminated; the Flash memory is mapped into data memory and can be read by means of using the LD instruction.

 

Thank you. I just found an article on wikipedia mentioning this.

Top
Milo-D
Milo-D's picture
Level: Wannabe
Joined: Fri. Nov 1, 2019
Posts: 67 View posts
Posted by Milo-D: Fri. Mar 12, 2021 - 01:20 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

MattRW wrote:

Your decoder needs to track which CPU version you have: AVRe vs AVRxm vs AVRxt vs AVRrc.

Look at the instruction manual.

 

EDIT: look at the last line below

 

Yep, I see. Thank you. I knew that some instructions are not supported by all controllers, but I did not know that there are possible opcode collisions if I simply support all of them.

Top
MattRW
MattRW's picture
Level: Resident
Joined: Thu. Feb 14, 2019
Posts: 745 View posts
Location: Los Angeles area
Posted by MattRW: Fri. Mar 12, 2021 - 01:31 AM (Reply to #8)
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Quote:

Yep, I see. Thank you. I knew that some instructions are not supported by all controllers, but I did not know that there are possible opcode collisions if I simply support all of them.

 

It matters also if you want to install breakpoints and/or provide instruction timing.

Top
Milo-D
Milo-D's picture
Level: Wannabe
Joined: Fri. Nov 1, 2019
Posts: 67 View posts
Posted by Milo-D: Fri. Mar 12, 2021 - 11:20 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

MattRW wrote:

Quote:

Yep, I see. Thank you. I knew that some instructions are not supported by all controllers, but I did not know that there are possible opcode collisions if I simply support all of them.

 

It matters also if you want to install breakpoints and/or provide instruction timing.

 

Another question: Are there any other possible opcode collisions besides LDS ?

Top
MattRW
MattRW's picture
Level: Resident
Joined: Thu. Feb 14, 2019
Posts: 745 View posts
Location: Los Angeles area
Posted by MattRW: Fri. Mar 12, 2021 - 11:22 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Milo-D wrote:

Are there any other possible opcode collisions besides LDS ?

 

I think STS and STD.

Top
Milo-D
Milo-D's picture
Level: Wannabe
Joined: Fri. Nov 1, 2019
Posts: 67 View posts
Posted by Milo-D: Fri. Mar 12, 2021 - 11:30 PM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

MattRW wrote:

Milo-D wrote:

Are there any other possible opcode collisions besides LDS ?

 

I think STS and STD.

 

Thank you for the quick respond ^^ I am currently looking at the appendix...so all the other cores (AVRe, AVRe+, etc.) are basically extensions (or reduced sets) of the classic instruction set (except AVRrc which has two special instructions lds/sts 16-bit version) ?

Top
westfw
westfw's picture
Level: Raving Lunatic
Joined: Wed. Jun 19, 2002
Posts: 5051 View posts
Location: SF Bay area
Posted by westfw: Sat. Mar 13, 2021 - 02:38 AM
  • 1
  • 2
  • 3
  • 4
  • 5
Total votes: 0

Well, yeah.  Otherwise they'd (hopefully) call them something besides "AVR."
Major departures:

AVRrc only has 16 registers.

Very old RAM-less chips (AT90S1200, for example) are missing RAM-specific instructions (no X or Y, no stack instructions.)

Newer chips do not have the CPU registers (R0-R31) mapped into the memory space.

 

There are pretty good tables in the new Instruction-set manual...
 

Top