AVR Freaks

You should answer questions with sentences...If you can't bother with a response, why come here?

WHY are you making TWO CLOCK pulses FOR EVERY BIT that you send out? 

Or are you indicating that you do not send out 2 pulses (4 edges) every time?  Please explain.

Every bit must only have ONE clock pulse...that synchronously defines each bit (without clk it's simply a high or low data line & not bits at all).

 

SCLK_OFF;

SCLK_ON;

SCLK_OFF;

SCLK_ON;       

Don't tell me you rewrote all that code into post #1? Surely you just copy/paste the actual code you are building ??

This is exactly why you should make sure that your code at least builds before you post it!

 

(unless it's a build error you're asking about)

 

Then use copy & paste - do not manually re-type into the forum.

 

See Tip #1 for how to properly post source code (in my signature, below; may not be visible on mobile).

 

 

Please do not edit posts after people have commented on them!

 

You still haven't answered the question which  avrcandies  has asked you - twice!

 

That certainly seems like an error!

You indentation is all over the place - it makes you code harder to follow.

 

And all that unnecessary whitespace.

 

And please choose just one brace style - and stick to it!

 

void spi(char cd,unsigned char myData)
{
    char i;

    cs = 0;
    sclk = 0;
    sda = cd;
    sclk = 1;

    for(i=0;i<8;i++)
    {
        sclk = 0;

        if(myData & 0x80)
            sda = 1;
        else
            sda = 0;

        sclk = 1;

        myData <<= 1;
        Delay10TCYx(20);
    }

    cs = 1;
}

 

Indeed, the code currently in #1 is now similar:

 

void send_bits(unsigned char cmd_,unsigned char data)
{
    unsigned char i;

    CS_OFF;
    SCLK_OFF;

    //send command or data
    if(cmd_)
    {
        SDA_ON;
    }
    else
    {
        SDA_OFF;
    }

    SCLK_ON;

    for ( i = 0 ; i < 8 ; i++ )
    {
        SCLK_OFF;

        if ( data & 0x80 )
        {
            SDA_ON;
        }
        else
        {
            SDA_OFF;
        }

        SCLK_ON;
        data <<= 1;
    }

}

But is that what you originally posted?

 

 

EDIT

 

One key difference between that spi() function and your send_bits() is that you have no delay - are you sure that's OK?

 

Remember that the timing of PIC code is likely to be different from timing of AVR code - so have you checked that your code meets the LCD's timing requirements ?

 

Show a schematic of your connections.