AVR Freaks

Or just like your previous post, where the problem turned out to be due to basic programming errors within a function - but you never showed the code inside that function!

How do you expect anyone to be able to remotely debug code that they cannot see?!?!

Your frustration here is because you're practising "hipshot programming"

Indeed.

AKA Shotgun Programming

AKA Throw The Dice Programming

AKA Crapshoot Programming

+ many more euphemisms!

Sadly, this is not just newbie territory. Mea Culpa. It seems often associated with not knowing what you are doing. Again Mea Culpa. Especially prevalent among those of us who are "self taught". Mea Culpa. I hope that my practice is now less subject to this style of programming, with huge thanks to those who have taken the time and effort so that a few of us from the unwashed masses can learn some important programming stuff.

Jim

No Theone.

What you need to do is post here a minimal but complete program that we can copy into our AVR Studio and test ourselves. Everything needs to be there so that we  can build it. E.g. the necessary #include directives, function heads etc. The above is definitively not a program that builds clean. It does not even have a header for the main() function - something every C program must have or else it will not build (let alone run).

I would also advice you to take on one of the common coding styles. There is virtually no-one that load a whole bunch of statements on one line like you do:

while(30 < MyNewString[inStringPos] && MyNewString[inStringPos] != 61){ MyArray1[outStringPos] = MyNewString[inStringPos]; inStringPos++; outStringPos++; MySerialOut("Got here1 ",&MyNewString[inStringPos]); }

Get used to instead place only one statment on each line, e.g. like so:

while(30 < MyNewString[inStringPos] && MyNewString[inStringPos] != 61)
{
    MyArray1[outStringPos] = MyNewString[inStringPos];
    inStringPos++;
    outStringPos++;
    MySerialOut("Got here1 ",&MyNewString[inStringPos]);
}

This makes for much easier reading.

Even if you don't like that style you must understand that close to 100% of the people you are asking for help does. If you don't make an effort to spare the potential helpers a lot of effort to be able to actually read your code then they will probably not spend the effort to help you.

I started trying to clean up your code above in this respect, but gave up after a while. It is not us that should do that cleaning up - it is you.

After cleaning your minimal demonstration program up the simple way to post it here is to

1) Mark everything in the editor/IDE you use to edit your code.

2) Copy that.

3) Create a post here.

4) Select the code "tool" (the button marked with "<>".

5) Paste what you copied earlier.

6) Click OK.

7) Click the Post button.

You can see above in this post of mine what the code "tool" does in a post. A box with light blue background, and a monospaced font used for the code text. That makes it much easier to read.

Doing what I have advised you to here will increase you chances of us actually reading your code and try to help you sort it out. Not doing it will likely make people turn to other questions that they find more interesting and workable. It's totally up to you.

EDIT: You have shown us the actual otput of the program. Please tell us what output you expected/desired. This is important!

I can spot one problem already in the small part of code I cleaned up above. The code is supposed to collect two characters, e.g. "aa" in the example input data you have give. When it has done that it will call the MySerialOut() like so:

		    MySerialOut("1st char",MyArray1);

In MySerialOut you use the two parameters when calling strcpy and strcat. Both of those functions expect C strings as their parameters. C strings are not exactly the same as a simple array of characters. Compared to "plain" arrays there is one extra feature of C strings: They must have a null character as their last character - it marks the end of the string.

Now, the way you collect characters into e.g. MyArray1 it is your responsibility to add this null character. It is also your responsibility to make sure the array can hold all the characters you collect and the terminating null character.

So, you need to change the declaration to

char MyArray1[3];  // Two characters and a null terminator. 2 + 1 -> 3

and then make sure you have the terminating null character ending the string:

    while(30 < MyNewString[inStringPos] && MyNewString[inStringPos] != 61){
		MyArray1[outStringPos] = MyNewString[inStringPos];
		inStringPos++;
		outStringPos++;
		MySerialOut("Got here1 ",&MyNewString[inStringPos]);
	}
    MyArray1[outStringPos] = 0;      // <-- Null terminator!

Caveat Emptor! I make no guarantees that the above is correct to the last letter. I also make no guarantees that this is the only problem with your code.

Had you posted a complete program that builds clean I could have tested it in AVR Studio, but I was not in the mood to convert what you posted into something I could actually run. (Again that is what you should have done.)

HTH!

Perhaps.  Also, perhaps someone once told OP that single-line functions are appropriate.

Ok. You're your own boss here.